Summary | Cannot open message |
Queue | IMP |
Queue Version | 6.0.5 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | azurit (at) pobox (dot) sk |
Created | 06/03/2013 (4413 days ago) |
Due | |
Updated | 06/05/2013 (4411 days ago) |
Assigned | 06/04/2013 (4412 days ago) |
Resolved | 06/05/2013 (4411 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
containt private data? Thank you.
State ⇒ Resolved
sure why I wasn't seeing this however.
commit ba2f9031f787ba404e0645e42678d3e344cdbccc
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Jun 5 12:48:17 2013 -0600
[mms] Fix displaying some HTML messages that contain blocked CSS
rules (
Bug #12294).Conflicts:
imp/docs/CHANGES
imp/package.xml
imp/docs/CHANGES | 2 ++
imp/lib/Mime/Viewer/Html.php | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/ba2f9031f787ba404e0645e42678d3e344cdbccc
commit a61408f869b7f3795e8fba2976c7df9724c476db
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Jun 5 12:48:17 2013 -0600
[mms] Fix displaying some HTML messages that contain blocked CSS
rules (
Bug #12294).imp/docs/CHANGES | 2 ++
imp/lib/Mime/Viewer/Html.php | 4 ++--
imp/package.xml | 2 ++
3 files changed, 6 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/a61408f869b7f3795e8fba2976c7df9724c476db
http://forums.phpfreaks.com/topic/268114-fatal-error-call-to-a-member-function-appendchild/
i'm using PHP 5.3.25
[05-Jun-2013 11:05:00 Europe/Bratislava] PHP Fatal error: Call to a
member function appendChild() on a non-object in
/usr/share/horde/imp/lib/Mime/Viewer/Html.php on line 512
commit c02cf9f512a29f4160bb39e0b54d922b57a69940
Author: Michael M Slusarz <slusarz@horde.org>
Date: Tue Jun 4 13:02:24 2013 -0600
[mms] Catch and ignore errors from contacts backend when
determining whether to show images in a message (
Bug #12294).imp/docs/CHANGES | 8 ++++++++
imp/lib/Images.php | 33 ++++++++++++++++++++-------------
2 files changed, 28 insertions(+), 13 deletions(-)
http://git.horde.org/horde-git/-/commit/c02cf9f512a29f4160bb39e0b54d922b57a69940
I would trace the code (renderIMP method), putting in breakpoints
until you reach the point where it doesn't work anymore.
Thank you.
you. I can verify that the CSS parsing code works perfectly for me
and I can view the message part just fine.
State ⇒ Feedback
The only thing I could reproduce is if the image lookup in Turba was
broken. So this patch might help.
commit 4997624663ad7ab4541c1778877c5652b7247125
Author: Michael M Slusarz <slusarz@horde.org>
Date: Tue Jun 4 13:02:24 2013 -0600
[mms] Catch and ignore errors from contacts backend when
determining whether to show images in a message (
Bug #12294).imp/docs/CHANGES | 2 ++
imp/lib/Ui/Imageview.php | 32 +++++++++++++++++++-------------
imp/package.xml | 4 ++--
3 files changed, 23 insertions(+), 15 deletions(-)
http://git.horde.org/horde-git/-/commit/4997624663ad7ab4541c1778877c5652b7247125
Assigned to Michael Slusarz
State ⇒ Assigned
https://github.com/horde/horde/commit/2b5411859c870bffc70c0aff60ced9d9038b78ec
(which doesn't work) and 6.1 (which works). Which is why I couldn't
reproduce.
https://github.com/horde/horde/commit/2b5411859c870bffc70c0aff60ced9d9038b78ec
I also checked if it's correct and copy file
'imp/lib/Mime/Viewer/Html.php' from 6.0.4 to 6.0.5 and problem
disappears.
packages on newest stable versions so problem must be really directly
in imp and was introduced in 6.0.5.
File: Horde/Imap/Client/Base/Debug.php
Function: _write (at the end of file)
This is at the end of function _write:
if (substr($msg, -1) == "\n") {
fwrite($this->_stream, $pre . $msg);
$this->_buffer = null;
} else {
$this->_buffer = $pre . $msg;
}
Data which are ok goes into the 'if'. The missing part of data is
going to the 'else'. Looks like the missing part does not have the EOL
character so IMP is considering it as partial message and is not
processing it. The same thing is, probably, hapening also when
displaying the message.
from 6.0.4 to 6.0.5. Where should i start with debugging?
code this text is not being recognized. I don't care what the actual
text is. (E.g. this could be some weird fread() boundary issue, so
only by debugging the actual code reading the stream in Imap_Client
are you going to determine the root cause).
New Attachment: data.txt
by syslog but directly into the file with:
'debug' => '/tmp/imp-debug.txt',
'debug_raw' => true,
in my backends.local.php
by syslog, if that is your logging backend.
can see the data in tcpdump when sniffing the communication. They are
only missing in IMP debug log.
interesting it that i'm able to correctly open the message via
Thunderbird.
get that body part.
As mentioned - I can't reproduce with any of my test servers. So I
can't do anything more from this side.
You can try to manually login to your IMAP server (i.e. via telnet)
and issue these commands and see how it responds:
1 SELECT "INBOX"
2 UID FETCH 404611 (BODY.PEEK[2.2])
interesting it that i'm able to correctly open the message via
Thunderbird.
State ⇒ Not A Bug
can be produced otherwise). If an IMAP server doesn't provide us with
required data input, there's nothing we can do and no way to workaround.
4.8.0. Sholud i contact the Courier author?
Priority ⇒ 1. Low
State ⇒ Feedback
According to your IMAP log, the request for BODY part 2.2 is returning
no data, although the server is claiming there should be 2256 octets
of literal data:
C: 9 UID FETCH 404611 (BODY.PEEK[2.2])
S: * 3983 FETCH (UID 404611 BODY[2.2] {2256}
S: )
S: 9 OK FETCH completed.
I can verify this works for me on my Courier test server:
C: 8 UID FETCH 1 (BODY.PEEK[2.2])
S: * 1 FETCH (UID 1 BODY[2.2] {2256}
S: [LITERAL DATA: 2256 bytes]
S: )
S: 8 OK FETCH completed.
New Attachment: 1370267560.M453632P28419V0000000000000902I0000000006EB8DB5_0.server00,S=9473:2,S
Priority ⇒ 2. Medium
State ⇒ Unconfirmed
New Attachment: imp-debug.txt
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Type ⇒ Bug
Summary ⇒ Cannot open message
Error when communicating with the server.
Attaching the IMAP log. Notice that IMP is disconnecting early at the
end (it usually sends few other commands when opening a message).