6.0.0-beta1
7/26/25

[#12207] Wrong arguments passed to storage->remove() in prefs->remove()
Summary Wrong arguments passed to storage->remove() in prefs->remove()
Queue Horde Base
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester manuel (at) mausz (dot) at
Created 04/23/2013 (4477 days ago)
Due
Updated 04/23/2013 (4477 days ago)
Assigned
Resolved 04/23/2013 (4477 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
04/23/2013 10:02:02 PM Michael Slusarz Comment #3
Assigned to Michael Slusarz
State ⇒ Resolved
Reply to this comment
Horde_Prefs 2.3.3.
04/23/2013 10:01:56 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 3a05bed6afc0d35b66f41b34439d98577ff17f3d
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Tue Apr 23 16:01:23 2013 -0600

     [mms] Fix removing preference from backend (Bug #12207).

  framework/Prefs/lib/Horde/Prefs.php |    2 +-
  framework/Prefs/package.xml         |    2 ++
  2 files changed, 3 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/3a05bed6afc0d35b66f41b34439d98577ff17f3d
04/23/2013 09:50:23 AM manuel (at) mausz (dot) at Comment #1
Priority ⇒ 1. Low
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Horde Base
Summary ⇒ Wrong arguments passed to storage->remove() in prefs->remove()
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
The subject says it all:
Signature in Horde/Prefs/Storage/Base.php:
abstract public function remove($scope = null, $pref = null);

https://github.com/horde/horde/blob/master/framework/Prefs/lib/Horde/Prefs/Storage/Base.php#L86 
)

Call in Horde/Prefs.php:
$storage->remove($prefname);

https://github.com/horde/horde/blob/master/framework/Prefs/lib/Horde/Prefs.php#L167 
)

Fix:
Change
$storage->remove($prefname);
to
$storage->remove($scope->scope, $prefname);

Saved Queries