| Summary | ActiveSync: Fix importing "low" importance setting on tasks |
| Queue | Synchronization |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | mrubinsk (at) horde (dot) org |
| Requester | thomas.jarosch (at) intra2net (dot) com |
| Created | 04/19/2013 (4649 days ago) |
| Due | |
| Updated | 04/22/2013 (4646 days ago) |
| Assigned | |
| Resolved | 04/19/2013 (4649 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
commit 1b4fc14eeeab4a98e92538143eef3abaa9ad7dd5
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Fri Apr 19 17:09:50 2013 -0400
Bug: 12197Fix returning default value when value is defined, but empty..../lib/Horde/ActiveSync/Message/Base.php | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/1b4fc14eeeab4a98e92538143eef3abaa9ad7dd5
Assigned to Michael Rubinsky
State ⇒ Resolved
commit fa7ba65815331488ee369ae0cf605553ff9f233b
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Fri Apr 19 17:09:50 2013 -0400
Bug: 12197Fix returning default value when value is defined, but empty..../lib/Horde/ActiveSync/Message/Base.php | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/fa7ba65815331488ee369ae0cf605553ff9f233b
Patch ⇒ Yes
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ ActiveSync: Fix importing "low" importance setting on tasks
Queue ⇒ Synchronization
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
setting a "low" importance value for a task is not properly imported
from the PIM.
It will always turn up as "normal" importance.
The AS value for low importance is zero. The importance flag is
queried via getImportance() which in turn uses _getAttribute(). Since
empty() returns true for "0", we will use the default value of "normal".
Classic empty() vs. isset() problem. Attached patch fixes the issue.
Cheers,
Thomas