Summary | ActiveSync: Country field is not synced |
Queue | Turba |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | mrubinsk (at) horde (dot) org |
Requester | thomas.jarosch (at) intra2net (dot) com |
Created | 04/18/2013 (4461 days ago) |
Due | |
Updated | 04/22/2013 (4457 days ago) |
Assigned | 04/18/2013 (4461 days ago) |
Resolved | 04/19/2013 (4460 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
I've backported it manually for me to FRAMEWORK_5_0, I want that new
feature :)
Assigned to Michael Rubinsky
State ⇒ Resolved
commit ab1d84d2492baf38fa2c2b3f227fe46f85e4f100
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Fri Apr 19 15:01:37 2013 -0400
Support "free" country fields as well.
If both free and non-free country fields are defined in a source,
the "free" version will take precedence.
Request: 12192turba/lib/Driver.php | 54 ++++++++++++++++++++++++++++++++++++-------------
1 files changed, 39 insertions(+), 15 deletions(-)
http://git.horde.org/horde-git/-/commit/ab1d84d2492baf38fa2c2b3f227fe46f85e4f100
before at all?
So this should be no problem.
with the other fields that require special handling and can't just be
copied over in a loop. It needs to be converted to/from the ISO
country codes.
If you want the free-form country fields to be supported as an option
(and I agree it would be a good idea), we should decide which field to
standardize on when sending/receiving from the sync client. We
probably need to keep the iso fields to avoid them getting corrupted
by non-iso names form the client. Then it's just a matter of detecting
the field in use on the Turba side, and converting it if necessary
to/from the iso names.
2b9e0896111eb40b02324a827fc6177e2d6fa660
Jan fixed this later on.
imaddress stuff. Though I don't mind getting the code applied :o)
feel like if I ever coded while I was not half asleep for a change. :)
Sorry, but I'll have to revert it until it's implemented as above :)
and the corresponding [home|other|work]Country field then the later
will overwrite the former. The non-free version is the ISO country
code, not free text, and is converted to the ISO country name before
being sent to the device.
before at all?
So this should be no problem.
btw: You commited the patch file for this in
2b9e0896111eb40b02324a827fc6177e2d6fa660
Jan fixed this later on. You also commited the code changes
accidentally together with the imaddress stuff. Though I don't mind
getting the code applied :o)
State ⇒ Feedback
and the corresponding [home|other|work]Country field then the later
will overwrite the former. The non-free version is the ISO country
code, not free text, and is converted to the ISO country name before
being sent to the device.
Patch ⇒ Yes
New Attachment: 0001-ActiveSync-Add-support-to-sync-the-country-fields-bu.patch
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Turba
Summary ⇒ ActiveSync: Country field is not synced
Type ⇒ Bug
attached patch adds support to sync the country fields.
I've tested the work and home country field.
Cheers,
Thomas