Summary | ActiveSync: Trouble selecting the default addressbook on contact add/modify |
Queue | Turba |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | mrubinsk (at) horde (dot) org |
Requester | thomas.jarosch (at) intra2net (dot) com |
Created | 04/17/2013 (4459 days ago) |
Due | |
Updated | 04/17/2013 (4459 days ago) |
Assigned | 04/17/2013 (4459 days ago) |
Resolved | 04/17/2013 (4459 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
commit 2352b62c7d9cab901653be773a8169c3809aa632
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Wed Apr 17 12:48:34 2013 -0400
Bug: 12188Be more consistent with address book selection.Really need to clean up default addressbook stuff in general, but
this avoids issues with syncing in the meantime.
Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>
turba/lib/Api.php | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/2352b62c7d9cab901653be773a8169c3809aa632
Queue ⇒ Turba
commit 0b9833bbcfa2b43f3473bdaf2eaa44836df6128d
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Wed Apr 17 12:48:34 2013 -0400
Bug: 12188Be more consistent with address book selection.Really need to clean up default addressbook stuff in general, but
this avoids issues with syncing in the meantime.
Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>
turba/lib/Api.php | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/0b9833bbcfa2b43f3473bdaf2eaa44836df6128d
Assigned to Michael Rubinsky
State ⇒ Assigned
State ⇒ Duplicate
New Attachment: 0001-Fix-selecting-default-addressbook-if-default_dir-syn.patch
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ ActiveSync: Trouble selecting the default addressbook on contact add/modify
Queue ⇒ Synchronization
Milestone ⇒
Patch ⇒ Yes
State ⇒ Unconfirmed
I've just debugged a silly problem for two hours. My account has two
contact shares:
- "BACKUP"
- "Contacts"
I've never configured the "default_dir" or "sync_books" prefs. I've
added a new contact via ActiveSync and by chance it ended up in the
"Contacts" share.
Next I modified the contact on the AS device again. This modification
never made it to the server, the ActiveSync log always complained it
does not find the object with the given UID.
The problem boils down to this:
- turba/lib/Api.php:_getSources() as used by Api.php:replace()
falls back to Turba::getDefaultAddressbook() in case "sync_books"
is not set.
- Api.php:import() uses the first editable addressbook instead.
The attached patch make this more consistent by trying
the default addressbook first on import().
Similar problem: When the user configures a default addressbook that
is not part of "sync_books", the same problem will appear again. It
would be nice if we could output a warning if that's the case.
May be via a "warning notification"?
Thomas