Tickets :: [#12164] Horde_Pear doesn't check for XML errors

6.0.0-beta1

7/6/25

Summary	Horde_Pear doesn't check for XML errors
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	math.parent (at) gmail (dot) com
Created	04/08/2013 (4472 days ago)
Due
Updated	12/17/2013 (4219 days ago)
Assigned
Resolved	11/13/2013 (4253 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

12/17/2013 11:40:01 AM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git (master): commit bb469365ed8f796a12a8a03ae32ab2accad00b64 Author: Michael M Slusarz <slusarz@horde.org> Date: Tue Nov 12 21:12:17 2013 -0700 [mms] Report XML parsing errors (~~Request #12164~~; math.parent@gmail.com). framework/Pear/lib/Horde/Pear/Package/Xml.php \| 27 ++++++++++++++++++++++++- framework/Pear/package.xml \| 4 +- 2 files changed, 28 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/bb469365ed8f796a12a8a03ae32ab2accad00b64

12/17/2013 11:39:44 AM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git (master): commit 1f8a4238bffd0a4abcdd9bef216559a98e35f744 Author: Michael M Slusarz <slusarz@horde.org> Date: Tue Nov 12 21:12:17 2013 -0700 [mms] Report XML parsing errors (~~Request #12164~~; math.parent@gmail.com). framework/Pear/lib/Horde/Pear/Package/Xml.php \| 27 ++++++++++++++++++++++++- framework/Pear/package.xml \| 4 +- 2 files changed, 28 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/1f8a4238bffd0a4abcdd9bef216559a98e35f744

12/17/2013 11:39:26 AM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (master): commit 7195e21f3fd73116f8317a6db553880d7290ce55 Author: Michael M Slusarz <slusarz@horde.org> Date: Tue Nov 12 21:12:17 2013 -0700 [mms] Report XML parsing errors (~~Request #12164~~; math.parent@gmail.com). framework/Pear/lib/Horde/Pear/Package/Xml.php \| 27 ++++++++++++++++++++++++- framework/Pear/package.xml \| 4 +- 2 files changed, 28 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/7195e21f3fd73116f8317a6db553880d7290ce55

12/17/2013 11:39:09 AM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (master): commit 6a6f389f7ab9dd98fbd3d546ce4269887454c59f Author: Michael M Slusarz <slusarz@horde.org> Date: Tue Nov 12 21:12:17 2013 -0700 [mms] Report XML parsing errors (~~Request #12164~~; math.parent@gmail.com). framework/Pear/lib/Horde/Pear/Package/Xml.php \| 27 ++++++++++++++++++++++++- framework/Pear/package.xml \| 4 +- 2 files changed, 28 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/6a6f389f7ab9dd98fbd3d546ce4269887454c59f

11/13/2013 04:13:36 AM	Michael Slusarz	Comment #3 Assigned to Michael Slusarz State ⇒ Resolved	Reply to this comment
I'm not 100% sure what this best solution is either. But best to implement this now - as it provides more feedback than currently. Can always tweak later.

11/13/2013 04:12:58 AM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (master): commit f200f281e6664ecd6d2eb2ddbe288f279592fc44 Author: Michael M Slusarz <slusarz@horde.org> Date: Tue Nov 12 21:12:17 2013 -0700 [mms] Report XML parsing errors (~~Request #12164~~; math.parent@gmail.com). framework/Pear/lib/Horde/Pear/Package/Xml.php \| 27 ++++++++++++++++++++++++- framework/Pear/package.xml \| 4 +- 2 files changed, 28 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/f200f281e6664ecd6d2eb2ddbe288f279592fc44

04/08/2013 01:05:01 PM	math (dot) parent (at) gmail (dot) com	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Horde_Pear doesn't check for XML errors Queue ⇒ Horde Framework Packages Milestone ⇒ Patch ⇒ Yes New Attachment: domdocument-errors.diff State ⇒ Unconfirmed	Reply to this comment
When there is an error in Horde_Pear_Package_Xml constructor (mostly during ->loadXml), it is printed as a PHP warning and not intercepted. I'm not sure what should be done, maybe an exception (on fatal errors at least). Attached is an incomplete patch (tell me what to do).