| Summary | Tasks in portal view may have an invalid share name |
| Queue | Nag |
| Queue Version | 4.0.2 |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | jan (at) horde (dot) org |
| Requester | lauffer (at) ph-freiburg (dot) de |
| Created | 03/20/2013 (4499 days ago) |
| Due | |
| Updated | 03/25/2013 (4494 days ago) |
| Assigned | |
| Resolved | 03/25/2013 (4494 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
State ⇒ Resolved
commit 125088d433e9fffee555a060b289056aae1add7b
Author: Jan Schneider <jan@horde.org>
Date: Mon Mar 25 12:13:42 2013 +0100
[jan] Fix default task list in portal block (
Bug #12133).nag/docs/CHANGES | 1 +
nag/lib/Block/Summary.php | 2 +-
nag/package.xml | 2 ++
3 files changed, 4 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/125088d433e9fffee555a060b289056aae1add7b
profiles).
half a year ago:
https://github.com/horde/horde/commit/9f27dccb44f9f4e52de9f464a2f33c60d4d673ab
function _getShare($name) got an invalid share name... but this
doesn't change anything...
Priority ⇒ 1. Low
New Attachment: nag_Summary.php.patch
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Nag
Summary ⇒ Tasks in portal view may have an invalid share name
Type ⇒ Bug
State ⇒ Unconfirmed
If you remove and add the "Tasks Summary" in the portal view
without(!) saving the settings of the new Tasks Summary element you
get an invalid share name (see protected function _getShares(array
$ids) in Horde/Share/Sql.php).
It ends up in a error like:
"Share name lauffer not found"
(funny: first we saw a invalid share name called "jan" at some user profiles).
The problem is caused by an invalid default value (afterwards stored
in the horde_prefs at the show_tasklists key) with the login of the
user. The function above expects a "crypted" share names but instead
pass something matching for share owner.
You find the origin for this default in our nag file lib/Block/Summary.php
I would say we could initial an empty array() instead, see the simple patch.
What would you say?
Best regards and thank you for your support,
Stephan