Summary | Unicode Domains are passed to sendmail -> Can't send emails to/from unicode domains |
Queue | Horde Framework Packages |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | peter.meier+horde (at) immerda (dot) ch |
Created | 03/14/2013 (4498 days ago) |
Due | |
Updated | 04/01/2013 (4480 days ago) |
Assigned | 03/15/2013 (4497 days ago) |
Resolved | 03/16/2013 (4496 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
encoded as IDN, as $from is not touched.
commit 03da9ed59c80288992a3bd205701b1c820fcaf2f
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sun Mar 31 19:37:51 2013 -0600
Bug #12116: Also need to IDN encode from addresses before sendingframework/Mail/lib/Horde/Mail/Transport.php | 31 ++++++++++++++++++
framework/Mail/lib/Horde/Mail/Transport/Mock.php | 5 ++-
.../Mail/lib/Horde/Mail/Transport/Sendmail.php | 21 +-----------
framework/Mail/lib/Horde/Mail/Transport/Smtp.php | 19 +++--------
framework/Mail/lib/Horde/Mail/Transport/Smtpmx.php | 12 ++-----
framework/Mail/test/Horde/Mail/SendTest.php | 34
+++++++++++++++++---
6 files changed, 73 insertions(+), 49 deletions(-)
http://git.horde.org/horde-git/-/commit/03da9ed59c80288992a3bd205701b1c820fcaf2f
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Mar 15 18:49:02 2013 -0600
[mms] Correctly encode IDN domains when sending mail (
Bug #12116).However it does not fix it if the sending address should also be
encoded as IDN, as $from is not touched.
As a workaround I added:
$from = new Horde_Mail_Rfc822_Address($from);
$from = $from->writeAddress(array('idn' => true));
before:
$mail = @popen($this->_sendmailPath .
(empty($this->_sendmailArgs) ? '' : ' ' . $this->_sendmailArgs) . ' -f
' . escapeshellarg($from) . ' -- ' . $recipients, 'w');
Should I open a new ticket for this issue?
State ⇒ Resolved
commit c7eea0d03139cd8994cef27be3d9cfcfdec6b346
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Mar 15 18:49:02 2013 -0600
[mms] Correctly encode IDN domains when sending mail (
Bug #12116).framework/Mail/lib/Horde/Mail/Transport.php | 16 ++++++++++++----
framework/Mail/package.xml | 4 ++--
framework/Mail/test/Horde/Mail/SendTest.php | 15 +++++++++++++++
3 files changed, 29 insertions(+), 6 deletions(-)
http://git.horde.org/horde-git/-/commit/c7eea0d03139cd8994cef27be3d9cfcfdec6b346
Assigned to Michael Slusarz
Queue ⇒ Horde Framework Packages
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ Unicode Domains are passed to sendmail -> Can't send emails to/from unicode domains
Type ⇒ Bug
passed down in the framework as idn-encoded. Such an e-mail will still
be passed as unicode to sendmail.
This happens because on L112 of Horde/Mail/Transport/Sendmail.php [1]
the recipients are parsed (again). So on Line 111 a unicode domain is
idn-encoded, while on Line 113 they are back as unicode domains.
This makes it impossible to send as a unicode domain user, nor send
mails to a unicode domain.
[1]
https://github.com/horde/horde/blob/master/framework/Mail/lib/Horde/Mail/Transport/Sendmail.php#L112