| Summary | display_folder() hook: Child mailbox of hidden parent is not shown |
| Queue | IMP |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | slusarz (at) horde (dot) org |
| Requester | thomas.jarosch (at) intra2net (dot) com |
| Created | 02/22/2013 (4529 days ago) |
| Due | |
| Updated | 03/04/2013 (4519 days ago) |
| Assigned | 02/24/2013 (4527 days ago) |
| Resolved | 03/04/2013 (4519 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
folders either exist or not. (Virtual folders also have special
properties - they can never be a container, they never have children -
so they aren't a useful proxy here).
commit 581d81aeb0885a65436f94399620e8c8c6b261b1
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sat Mar 2 20:22:57 2013 -0700
Bug #12065: This should fix thingsimp/lib/Imap/Tree.php | 14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)
http://git.horde.org/horde-git/-/commit/581d81aeb0885a65436f94399620e8c8c6b261b1
The parent and child folder are shown now. The "disabled" parent
folder is clickable though and shows the mail content.
Would it be possible to treat it just like a non-existing, "virtual" folder?
commit 367e93deabbcea3be4e9e657a5442a51b2a24386
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Feb 28 19:57:47 2013 -0700
Bug #12065: Even if mailbox is invisible, muight still need toshow if it has children
imp/lib/Imap/Tree.php | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/367e93deabbcea3be4e9e657a5442a51b2a24386
display_folder(INBOX): 1
display_folder(INBOX/Drafts): 1
display_folder(INBOX/Kontakte): 0
display_folder(INBOX/Kontakte/E-Mail unter Kontakte): 1
display_folder(INBOX/Sent): 1
display_folder(vfolder): 1
display_folder(vfolder/impsearchvinbox): 1
(Actually a very simple fix - don't check isInvisible() if checking
for child active elements - but with the change I made earlier today
to fix the virtual folder display issue it makes more sense to
simply split the activeElt() into 2 completely separate methods
since the two modes no longer share any common test code).
It's stuck with "Loading...".
When I place a "return true;" statement at the end of the hook to show
all folders,
the folder list loads again.
Assigned to Michael Slusarz
State ⇒ Feedback
(Actually a very simple fix - don't check isInvisible() if checking
for child active elements - but with the change I made earlier today
to fix the virtual folder display issue it makes more sense to simply
split the activeElt() into 2 completely separate methods since the two
modes no longer share any common test code).
commit 601a6ad6426c76e9d6e173c85bd5cd0a04f98e41
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sat Feb 23 22:48:54 2013 -0700
Bug #12065: Don't do isInvsible() check if checking whethercurrent element has active children
imp/lib/Imap/Tree.php | 105 ++++++++++++++++++++++++++----------------------
1 files changed, 57 insertions(+), 48 deletions(-)
http://git.horde.org/horde-git/-/commit/601a6ad6426c76e9d6e173c85bd5cd0a04f98e41
Patch ⇒ No
State ⇒ Unconfirmed
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ display_folder() hook: Child mailbox of hidden parent is not shown
Type ⇒ Bug
Priority ⇒ 1. Low
a user just found out that child mailboxes of a hidden parent
are not shown in imp when using the display_folder() hook.
I would have expected they are handled like
non-existing IMAP hierarchy folders, so they get shown "grayed out".
In my concrete example, we use the "default" hook to hide
Kolab groupware data folders in imp. The user created a mail folder
below a calendar and this mail folder was not showing up.
I've verified that display_folder() gets called for the parent
and the child folder. Same behavior in the dynamic or basic view.
Cheers,
Thomas