| Summary | Horde_Pear fails when there is a comment in dependencies of a package.xml |
| Queue | Horde Framework Packages |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | jan (at) horde (dot) org |
| Requester | math.parent (at) gmail (dot) com |
| Created | 01/06/2013 (4552 days ago) |
| Due | |
| Updated | 05/23/2013 (4415 days ago) |
| Assigned | 01/15/2013 (4543 days ago) |
| Resolved | 05/23/2013 (4415 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
State ⇒ Resolved
====================
Fatal Error:
Unsupported dependency type "#comment"!
In
/home/mathieu/src/github.com/horde/horde/framework/Pear/lib/Horde/Pear/Package/Dependencies.php on line
56
1. Components::main()
/home/mathieu/src/github.com/horde/horde/components/bin/horde-components:16
2. Components_Module_Dependencies->handle()
/home/mathieu/src/github.com/horde/horde/components/lib/Components.php:70
3. Components_Runner_Dependencies->run()
/home/mathieu/src/github.com/horde/horde/components/lib/Components/Module/Dependencies.php:155
4. Components_Helper_Dependencies->listTree()
/home/mathieu/src/github.com/horde/horde/components/lib/Components/Runner/Dependencies.php:69
5. Components_Helper_Dependencies->_listTree()
/home/mathieu/src/github.com/horde/horde/components/lib/Components/Helper/Dependencies.php:85
6. Components_Component_DependencyList->rewind()
/home/mathieu/src/github.com/horde/horde/components/lib/Components/Helper/Dependencies.php:107
7. Components_Component_DependencyList->_getDependencies()
/home/mathieu/src/github.com/horde/horde/components/lib/Components/Component/DependencyList.php:125
8. Components_Component_Base->getDependencies()
/home/mathieu/src/github.com/horde/horde/components/lib/Components/Component/DependencyList.php:93
9. Horde_Pear_Package_Xml->getDependencies()
/home/mathieu/src/github.com/horde/horde/components/lib/Components/Component/Base.php:128
10. Horde_Pear_Package_Xml->_completeDependencies()
/home/mathieu/src/github.com/horde/horde/framework/Pear/lib/Horde/Pear/Package/Xml.php:220
11. Horde_Pear_Package_Dependencies::addDependency()
/home/mathieu/src/github.com/horde/horde/framework/Pear/lib/Horde/Pear/Package/Xml.php:250
====================
State ⇒ Feedback
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Horde_Pear fails when there is a comment in dependencies of a package.xml
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ Yes
New Attachment: 0001-Ignore-comments-in-package.xml-as-found-in-Horde_Kol.patch
State ⇒ Unconfirmed
php components/bin/horde-components ./framework/Kolab_Filter/ deps
I got:
Fatal Error:
Unsupported dependency type "#comment"!
In
/home/mathieu/src/github.com/horde/horde/framework/Pear/lib/Horde/Pear/Package/Dependencies.php on line
56
This is because "framework/Kolab_Filter/package.xml" contains a
comment in the optionnal dependencies [2].
The attached patch fixes it.
[1]: Or more exactly, from the $web_dir:
LANG=C php -d include_path="./libs:/usr/share/php:/usr/share/pear"
components/bin/horde-components ../horde/framework/Kolab_Filter/ deps
[2]:
https://github.com/horde/horde/blob/master/framework/Kolab_Filter/package.xml#L230