6.0.0-beta1
8/15/25

[#11898] Fix signature charset encoding
Summary Fix signature charset encoding
Queue IMP
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 12/17/2012 (4624 days ago)
Due
Updated 12/20/2012 (4621 days ago)
Assigned 12/20/2012 (4621 days ago)
Resolved 12/20/2012 (4621 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
12/20/2012 10:30:44 AM Thomas Jarosch Comment #6 Reply to this comment
IMP 6.0.3 (also fixes problem with converting trailer text).
Nice fix! Much easier to ready than mine.
s/ready/read/

12/20/2012 10:30:04 AM Thomas Jarosch Comment #5 Reply to this comment
IMP 6.0.3 (also fixes problem with converting trailer text).
Nice fix! Much easier to ready than mine.

12/20/2012 04:33:51 AM Michael Slusarz Comment #4
State ⇒ Resolved
Reply to this comment
IMP 6.0.3 (also fixes problem with converting trailer text).
12/20/2012 04:33:38 AM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 8d187910853d999edd33f66ed10b71c97285abff
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Wed Dec 19 21:31:47 2012 -0700

     [mms] Fix converting charset of signature/trailer in compose 
message if not sending in UTF-8 (Bug #11898).

  imp/docs/CHANGES    |    2 ++
  imp/lib/Compose.php |   10 +++++++---
  imp/package.xml     |    2 ++
  3 files changed, 11 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/8d187910853d999edd33f66ed10b71c97285abff
12/20/2012 04:23:30 AM Michael Slusarz Comment #2
Assigned to Michael Slusarz
State ⇒ Assigned
Reply to this comment
Things to review: Does the prefs backend always deliver UTF-8 values?
Yes.
12/17/2012 02:09:08 PM Thomas Jarosch Patch ⇒ Yes
New Attachment: 0001-Fix-signature-charset-encoding-Bug-11898.patch Download
 
12/17/2012 02:08:10 PM Thomas Jarosch Comment #1
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ Fix signature charset encoding
Type ⇒ Bug
Reply to this comment
Hi,

thanks to bug #11895, the sending_charset for my messages defaulted to 
iso-8859-1.

I was testing signatures with umlauts and wondered why
it contained "broken" UTF-8 umlauts.

Attached patch convert the signature into the desired charset
of the message instead of appending it blindly.


Things to review: Does the prefs backend always deliver UTF-8 values?

Cheers,
Thomas

Saved Queries