6.0.0-beta1
7/5/25

[#11895] Fix default email sending charset on first login
Summary Fix default email sending charset on first login
Queue Horde Base
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 12/17/2012 (4583 days ago)
Due
Updated 12/20/2012 (4580 days ago)
Assigned 12/18/2012 (4582 days ago)
Resolved 12/20/2012 (4580 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
12/20/2012 03:37:22 AM Michael Slusarz State ⇒ Resolved
 
12/19/2012 02:14:27 PM Thomas Jarosch Comment #5 Reply to this comment
Your fix is working, thanks!

I've also reviewed Prefs/Scope.php for fun (wanted to find out how it 
works) and looks good, too.

12/18/2012 06:05:02 AM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit 799f903d0c4012198cc306e9b2bfaa8f40da1e3f
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Dec 17 22:58:12 2012 -0700

     [mms] When removing a pref, reset its value in the cached scope 
to the default (Bug #11895).

  framework/Prefs/lib/Horde/Prefs/Scope.php |    6 +++++-
  framework/Prefs/package.xml               |    2 ++
  2 files changed, 7 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/799f903d0c4012198cc306e9b2bfaa8f40da1e3f
12/18/2012 06:04:24 AM Michael Slusarz Comment #3
State ⇒ Feedback
Reply to this comment
Strange thing: we weren't deleting the preference value in the 
backend.  This should now be fixed, and the preference value is set to 
the default.

This should fix.
12/17/2012 08:46:46 PM Michael Slusarz Comment #2
State ⇒ Assigned
Patch ⇒ No
Assigned to Michael Slusarz
Reply to this comment
on first login, the default email sending charset defaults to 
iso-8859-1 on my box.

Later logins contain UTF-8 as expected, I'll shortly attach a patch 
to fix it.
This patch isn't correct.  Removing the preference should change the 
value to the default, so that needs to be the correct fix.
12/17/2012 10:47:27 AM Thomas Jarosch Patch ⇒ Yes
New Attachment: 0001-Fix-default-email-sending-charset-on-first-login-Bug.patch Download
 
12/17/2012 10:44:46 AM Thomas Jarosch Comment #1
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Base
Summary ⇒ Fix default email sending charset on first login
Type ⇒ Bug
Reply to this comment
Hi,

on first login, the default email sending charset defaults to 
iso-8859-1 on my box.

Later logins contain UTF-8 as expected, I'll shortly attach a patch to fix it.

Cheers,
Thomas

Saved Queries