Summary | Kolab backend: All day events are not handled correctly |
Queue | Kronolith |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | jan (at) horde (dot) org |
Requester | thomas.jarosch (at) intra2net (dot) com |
Created | 11/27/2012 (4616 days ago) |
Due | |
Updated | 12/06/2012 (4607 days ago) |
Assigned | 11/27/2012 (4616 days ago) |
Resolved | 12/04/2012 (4609 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Thanks Jan!
commit 33c79e07c7891524e206b9a246d94f83e002c3ba
Author: Jan Schneider <jan@horde.org>
Date: Wed Dec 5 18:35:24 2012 +0100
Kolab stores all day events differently than anybody else, add a
day (
Bug #11767)..../lib/Horde/Kolab/Format/Xml/Event.php | 30
++++++++++++++++++++
.../Kolab/Format/Xml/Type/EventDateTime/V1.php | 29 +++++++++++++++++++
2 files changed, 59 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/33c79e07c7891524e206b9a246d94f83e002c3ba
commit b9f02aceb1f0e46c72d84f628a98a99878681b81
Author: Jan Schneider <jan@horde.org>
Date: Tue Dec 4 15:21:18 2012 +0100
[jan] Return date-only values as floating dates (
Bug #11767)..../Kolab_Format/lib/Horde/Kolab/Format/Date.php | 2 +-
framework/Kolab_Format/package.xml | 2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/b9f02aceb1f0e46c72d84f628a98a99878681b81
commit 8f1efb3680360f0cc20c673bbc7a8a3372de2959
Author: Jan Schneider <jan@horde.org>
Date: Tue Dec 4 12:48:29 2012 +0100
[jan] Correctly format all-day events (
Bug #11767)..../lib/Horde/Kolab/Format/Xml/Event.php | 28 +++++++++++++-
.../lib/Horde/Kolab/Format/Xml/Type/EventDate.php | 2 +-
.../Horde/Kolab/Format/Xml/Type/EventDate/V1.php | 2 +-
.../Horde/Kolab/Format/Xml/Type/EventDateTime.php | 38
++++++++++++++++++++
.../Kolab/Format/Xml/Type/EventDateTime/V1.php | 38
++++++++++++++++++++
framework/Kolab_Format/package.xml | 16 ++++++---
6 files changed, 115 insertions(+), 9 deletions(-)
http://git.horde.org/horde-git/-/commit/8f1efb3680360f0cc20c673bbc7a8a3372de2959
Assigned to Jan Schneider
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Kolab backend: All day events are not handled correctly
Queue ⇒ Kronolith
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
all day events are not handled correctly, at least not according to
the Kolab format specification.
The Kolab definition of all day events:
--------------------------------------
<event>
<start-date>(date or datetime)</start-date>
<end-date>(date or datetime)</end-date>
</event>
-> So "start-date" and "end-date" allows "date" or "datetime" values.
Later on the format specification clarifies:
"An event without a time but with a date associated is a full day
event. Such a full day event may span
over multiple days and may have recurrences."
The earlier section "Common in Tasks and Events" is even more specific:
"The start-date is optional for tasks. For events, it is required. If
they are there, they can either have a date or a datetime as the type.
Parsing this is just a matter of looking at the length of the date
string. In the case of an all day event (floating event) the end-date
MUST be in date only format."
--------------------------------------
-> Right now kronolith saves all day events with a timestamp. Also it
fails to parse all day events from other Kolab clients correctly. We
should write out all day events with an "end-date" as "date" only.
Thomas