Tickets :: [#11745] Activesync charset converting error

6.0.0-alpha14

6/23/25

Summary	Activesync charset converting error
Queue	Synchronization
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	horde (at) albasoft (dot) com
Created	11/22/2012 (4596 days ago)
Due
Updated	12/03/2012 (4585 days ago)
Assigned	12/02/2012 (4586 days ago)
Resolved	12/03/2012 (4585 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

12/03/2012 03:25:52 PM	Michael Rubinsky	Comment #5 State ⇒ Resolved	Reply to this comment
Totally missed that, thanks.

12/03/2012 03:25:29 PM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (master): commit ea31f9fb010d093c07b00c39f85533293f792cea Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Mon Dec 3 10:20:43 2012 -0500 ~~Bug: 11745~~ Remove duplicate, erroneous assignment from bad merge. .../lib/Horde/ActiveSync/Imap/Adapter.php \| 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/ea31f9fb010d093c07b00c39f85533293f792cea

12/03/2012 10:10:41 AM	horde (at) albasoft (dot) com	Comment #3	Reply to this comment
Which previous conversion is this reversing? The only other conversions are in the other conditional clauses that are mutually exclusive. framework / ActiveSync / lib / Horde / ActiveSync / Imap / Adapter.php, lines 920 and 923. I think 923 should not be there. Line 920 already makes a correct asignment to 'body'.

12/02/2012 10:38:02 PM	Michael Rubinsky	Comment #2 Priority ⇒ 1. Low State ⇒ Feedback	Reply to this comment
Activesync was not delivering iso-8859-1 emails correctly to devices. Looking into the code, I've found a line which undoes the previous conversion. Which previous conversion is this reversing? The only other conversions are in the other conditional clauses that are mutually exclusive. Deleting that line solves the problem. Can you describe, exactly, what the problem is?

11/28/2012 12:03:06 PM	Jan Schneider	State ⇒ Assigned Assigned to Michael Rubinsky

11/22/2012 03:20:19 PM	horde (at) albasoft (dot) com	Comment #1 Priority ⇒ 2. Medium Type ⇒ Bug Summary ⇒ Activesync charset converting error Queue ⇒ Synchronization Milestone ⇒ Patch ⇒ Yes State ⇒ Unconfirmed	Reply to this comment
Activesync was not delivering iso-8859-1 emails correctly to devices. Looking into the code, I've found a line which undoes the previous conversion. Deleting that line solves the problem. --- ActiveSync/Imap/Adapter.php.ori 2012-11-22 16:13:10.306357672 +0100 +++ ActiveSync/Imap/Adapter.php 2012-11-22 16:12:50.978606153 +0100 @@ -917,7 +917,6 @@ 'body' => Horde_String::convertCharset($message_body_data['plain']['body'], $message_body_data['plain']['charset'], 'UTF-8'), 'estimated_size' => $message_body_data['plain']['size'], 'truncated' => $message_body_data['plain']['truncated'], - 'body' => $message_body_data['plain']['body'] ); } else { $airsync_body->type = Horde_ActiveSync::BODYPREF_TYPE_HTML;