Summary | typos (lots) in preview |
Queue | IMP |
Queue Version | 6.0.1 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | viktor (at) szepe (dot) net |
Created | 11/19/2012 (4607 days ago) |
Due | |
Updated | 11/19/2012 (4607 days ago) |
Assigned | 11/19/2012 (4607 days ago) |
Resolved | 11/19/2012 (4607 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
Assigned to Michael Slusarz
State ⇒ Resolved
Priority ⇒ 1. Low
commit fd9905ba596c00c5992b23026933b5cec69b285f
Author: Michael M Slusarz <slusarz@horde.org>
Date: Mon Nov 19 16:50:47 2012 -0700
[mms] Fix preview message text in basic view (
Bug #11724).imp/docs/CHANGES | 1 +
imp/lib/Mailbox/List.php | 25 ++++++++++++++++---------
imp/package.xml | 2 ++
3 files changed, 19 insertions(+), 9 deletions(-)
http://git.horde.org/horde-git/-/commit/fd9905ba596c00c5992b23026933b5cec69b285f
foreach ($ids as $k => $v) {
if (!isset($fetch_res[$v])) {
continue;
}
$f = $fetch_res[$v];
$v = array(
'envelope' => $f->getEnvelope(),
'flags' => $f->getFlags(),
'headers' => $f->getHeaders('imp',
Horde_Imap_Client_Data_Fetch::HEADER_PARSE),
'idx' => $k,
'mailbox' => $mbox,
'size' => $f->getSize(),
'uid' => $f->getUid()
);
if (($options['preview'] === 2) ||
State ⇒ Feedback
$v is used instead of $k as index
around 8 times
patch: changes the [indexes] to $k
mailbox. That number can change on any future page load (which is
precisely why you are seeing incorrect messages being loaded).
$v is correctly used since it contains the UID of the message.
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ typos (lots) in preview
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ Yes
State ⇒ Unconfirmed
$v is used instead of $k as index
around 8 times
patch: changes the [indexes] to $k