Summary | Admin - User Management - adding and deleting do not work |
Queue | Horde Base |
Queue Version | 5.0.1 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | jan (at) horde (dot) org, slusarz (at) horde (dot) org |
Requester | aloyse.gilbert (at) gmail (dot) com |
Created | 11/12/2012 (4631 days ago) |
Due | |
Updated | 11/14/2012 (4629 days ago) |
Assigned | 11/13/2012 (4630 days ago) |
Resolved | 11/14/2012 (4629 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | 5.0.2 |
Patch | Yes |
State ⇒ Resolved
Milestone ⇒ 5.0.2
commit 6938cb9ff02cd75306a65a9fc84de5c96207d6bf
Author: Jan Schneider <jan@horde.org>
Date: Wed Nov 14 11:36:49 2012 +0100
[jan] Fix adding user in admin actions (
Bug #11690).horde/admin/user.php | 3 ++-
horde/docs/CHANGES | 1 +
horde/package.xml | 10 +++++-----
horde/templates/admin/user/add.inc | 3 ---
4 files changed, 8 insertions(+), 9 deletions(-)
http://git.horde.org/horde-git/-/commit/6938cb9ff02cd75306a65a9fc84de5c96207d6bf
Assigned to Jan Schneider
Priority ⇒ 2. Medium
State ⇒ Assigned
converted to git).
As for the add issue: that command was explicitly removed by Jan in
this commit:
commit 41f42830f21b9cd245877f074495a845543aa7ed
Author: Jan Schneider <jan@horde.org>
Date: Tue Nov 6 21:14:33 2012 +0100
[jan] Fix form for editing and removing of users.
So I will leave that part of this ticket for him to address.
commit 89a0346bc26856280569cfc5c95b67315ec957bc
Author: Michael M Slusarz <slusarz@horde.org>
Date: Tue Nov 13 15:42:53 2012 -0700
[mms] Fix removing user in admin actions (
Bug #11690).horde/docs/CHANGES | 1 +
horde/package.xml | 2 ++
horde/templates/admin/user/remove.inc | 2 ++
3 files changed, 5 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/89a0346bc26856280569cfc5c95b67315ec957bc
I can confirm the bug. In addition: Trying to add a user leads to a
removal of the user from the database, if the username already exists.
Configuration:
$conf['auth']['admins'] = array('xxx');
$conf['auth']['checkip'] = true;
$conf['auth']['checkbrowser'] = true;
$conf['auth']['resetpassword'] = true;
$conf['auth']['alternate_login'] = false;
$conf['auth']['redirect_on_logout'] = false;
$conf['auth']['list_users'] = 'list';
$conf['auth']['params']['driverconfig'] = 'horde';
$conf['auth']['params']['encryption'] = 'ssha';
$conf['auth']['params']['show_encryption'] = false;
$conf['auth']['driver'] = 'sql';
$conf['auth']['params']['count_bad_logins'] = false;
$conf['auth']['params']['login_block'] = false;
$conf['auth']['params']['login_block_count'] = 5;
$conf['auth']['params']['login_block_time'] = 5;
$conf['signup']['params']['driverconfig'] = 'horde';
$conf['signup']['driver'] = 'Sql';
$conf['signup']['approve'] = true;
$conf['signup']['allow'] = true;
IMHO this bug should have a high priority!
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Horde Base
Summary ⇒ Admin - User Management - adding and deleting do not work
Type ⇒ Bug
adding and removing users does not work on the Admin Page.
seems that some input fields are missing in the add.inc and remove.inc
template files.
the following changes solve the problem at the first glance, but I
don't have any ideas about side-effects and so on...
below is a diff against the master branch.hope it helps.
ag
------------------------------------------------------------
diff --git a/horde/templates/admin/user/add.inc
b/horde/templates/admin/user/add.inc
index a0d42ba..c19ff1e 100644
--- a/horde/templates/admin/user/add.inc
+++ b/horde/templates/admin/user/add.inc
@@ -1,3 +1,4 @@
<?php
+$vars->set('form', 'add');
$renderer = new Horde_Form_Renderer();
$addForm->renderActive($renderer, $vars, Horde::selfUrl(), 'post');
diff --git a/horde/templates/admin/user/remove.inc
b/horde/templates/admin/user/remove.inc
index 35540f5..7745e4e 100644
--- a/horde/templates/admin/user/remove.inc
+++ b/horde/templates/admin/user/remove.inc
@@ -1,5 +1,6 @@
<!--a75c305b1c0a6022--><form name="removeuser" action="<?php echo
Horde::selfUrl() ?>" method="post">
<input type="hidden" name="form" value="remove" />
+<input type="hidden" name="user_name" value="<?php echo
htmlspecialchars($f_user_name) ?>" />
<?php Horde_Util::pformInput() ?>
<h1 class="header">
------------------------------------------------------------