Tickets :: [#11653] Make Horde_Support compatible with both existing UUID extensions

6.0.0-beta1

7/17/25

Summary	Make Horde_Support compatible with both existing UUID extensions
Queue	Horde Framework Packages
Queue Version	Git master
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	remi (at) famillecollet (dot) com
Created	11/06/2012 (4636 days ago)
Due
Updated	11/06/2012 (4636 days ago)
Assigned
Resolved	11/06/2012 (4636 days ago)
Milestone
Patch	Yes

11/06/2012 05:42:55 PM	remi (at) famillecollet (dot) com	Comment #11	Reply to this comment
I wasn't talking about your patch, but the interface of the uuid Yes, I have understand ;) Thanks for the quick fix for this minor issue.

11/06/2012 05:40:20 PM	Jan Schneider	Comment #10	Reply to this comment
I wasn't talking about your patch, but the interface of the uuid extension. Your changes still make the code more readable, thanks!

11/06/2012 05:39:42 PM	Git Commit	Comment #9	Reply to this comment
Changes have been made in Git (master): commit f5da72cfe071e1231a4b539d09b187f8a98a2aa0 Author: Jan Schneider <jan@horde.org> Date: Tue Nov 6 18:39:11 2012 +0100 Make these tests semantically more correct (~~Bug #11653~~). framework/Support/lib/Horde/Support/Uuid.php \| 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/f5da72cfe071e1231a4b539d09b187f8a98a2aa0

11/06/2012 05:28:37 PM	remi (at) famillecollet (dot) com	Comment #8 New Attachment: php-horde-Horde-Support-uuid[1].patch	Reply to this comment
This new patch is probably more readable... Sorry for Coding Standard... I don't know the Horde usage.

11/06/2012 05:26:24 PM	Jan Schneider	Comment #7 State ⇒ Resolved Assigned to Jan Schneider	Reply to this comment
That's the most weird PHP interface I have seen. :)

11/06/2012 05:26:17 PM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git (master): commit c8c66fb546da37c0479eb72041c5eca58ef4eeb6 Author: Jan Schneider <jan@horde.org> Date: Tue Nov 6 18:25:45 2012 +0100 [jan] Support uuid extension from OSSP (remi@famillecollet.com, ~~Request #11653~~). framework/Support/lib/Horde/Support/Uuid.php \| 17 +++++++++++++++-- framework/Support/package.xml \| 4 ++-- 2 files changed, 17 insertions(+), 4 deletions(-) http://git.horde.org/horde-git/-/commit/c8c66fb546da37c0479eb72041c5eca58ef4eeb6

11/06/2012 05:22:25 PM	remi (at) famillecollet (dot) com	Comment #5	Reply to this comment
This functions return 0 on success, else a error code

11/06/2012 05:19:54 PM	Jan Schneider	Comment #4	Reply to this comment
The tests don't look correct though. Do these function really return false on success? Or do they return null? If the latter, how do they report errors back?

11/06/2012 05:12:58 PM	Jan Schneider	Comment #3	Reply to this comment
Scratch that, it's a run-time error not a compile-time error.

11/06/2012 05:12:13 PM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
This would create warnings if that extension is not installed, due to the constant usage. You need to use constant('XXX') instead.

11/06/2012 05:07:31 PM	remi (at) famillecollet (dot) com	Comment #1 Patch ⇒ Yes State ⇒ New New Attachment: php-horde-Horde-Support-uuid.patch Milestone ⇒ Queue ⇒ Horde Framework Packages Summary ⇒ Make Horde_Support compatible with both existing UUID extensions Type ⇒ Enhancement Priority ⇒ 1. Low	Reply to this comment
There is 2 UUID php extensions: http://www.ossp.org/pkg/lib/uuid/ http://pecl.php.net/package/uuid Horde_Support currently support the second. Fine. With the first installed, Horde_Support is broken (test suite fails). Attached patch make Horde_Support compatible with both, and test suite ok in the 3 cases (with first extension, with the second or without)