6.0.0-beta1
8/11/25

[#11585] Export of empty, shared task list dies
Summary Export of empty, shared task list dies
Queue Kronolith
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org, mrubinsk (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 10/29/2012 (4669 days ago)
Due
Updated 11/06/2012 (4661 days ago)
Assigned 11/01/2012 (4666 days ago)
Resolved 11/05/2012 (4662 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
11/06/2012 10:55:54 AM Thomas Jarosch Comment #8 Reply to this comment
Exporting empty and non-empty tasklists in nag still works ;)

11/05/2012 07:33:46 PM Git Commit Comment #7 Reply to this comment
Changes have been made in Git (master):

commit 1bf82910ccde59421ed217d58b65892551566fa9
Author: Jan Schneider <jan@horde.org>
Date:   Mon Nov 5 20:19:41 2012 +0100

     Don't throw exception if there is nothingto export (Bug #11585).

  mnemo/lib/Application.php |    5 +----
  nag/lib/Application.php   |    4 ----
  turba/lib/Application.php |    4 ----
  3 files changed, 1 insertions(+), 12 deletions(-)

http://git.horde.org/horde-git/-/commit/1bf82910ccde59421ed217d58b65892551566fa9
11/05/2012 07:18:43 PM Jan Schneider Assigned to Jan Schneider
State ⇒ Resolved
 
11/05/2012 07:12:02 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (master):

commit bad120ea788f3412ba755773d7ffd661bdaea3c9
Author: Jan Schneider <jan@horde.org>
Date:   Mon Nov 5 19:28:40 2012 +0100

     Don't throw exception if there are no events to export (Bug #11585).

  kronolith/lib/Application.php |    4 ----
  1 files changed, 0 insertions(+), 4 deletions(-)

http://git.horde.org/horde-git/-/commit/bad120ea788f3412ba755773d7ffd661bdaea3c9
11/05/2012 07:11:55 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (master):

commit 22fc67cd3833b04161236818bbf1f73bdacd9795
Author: Jan Schneider <jan@horde.org>
Date:   Mon Nov 5 19:24:19 2012 +0100

     Revert "Bug: 11585 Catch exceptions during download/export."

     This reverts commit fc776b2073fdb27de75a58de05a0ca57acaa1270.

     This won't work anyway, because we don't have a session started, so
     the notification gets lost.

  horde/services/download/index.php |   12 +++---------
  1 files changed, 3 insertions(+), 9 deletions(-)

http://git.horde.org/horde-git/-/commit/22fc67cd3833b04161236818bbf1f73bdacd9795
11/05/2012 11:10:03 AM Jan Schneider Comment #4 Reply to this comment
We should rather not throw an exception in this case, but return an 
empty task list.
11/01/2012 01:52:27 PM Michael Rubinsky Comment #3
State ⇒ Feedback
Assigned to Michael Rubinsky
Reply to this comment
How about now?
11/01/2012 01:52:08 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit fc776b2073fdb27de75a58de05a0ca57acaa1270
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Thu Nov 1 09:51:33 2012 -0400

     Bug: 11585 Catch exceptions during download/export.

  horde/services/download/index.php |   12 +++++++++---
  1 files changed, 9 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/fc776b2073fdb27de75a58de05a0ca57acaa1270
10/29/2012 11:50:54 AM Thomas Jarosch Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Export of empty, shared task list dies
Queue ⇒ Kronolith
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
Hi,

I tried to export an empty, shared task list. Will result in a fancy 
exception:

"There were no tasks to export.

1. Horde_Registry->callAppMethod() 
/datastore/DEVEL/horde/horde/services/download/index.php:33
2. call_user_func_array() 
/datastore/DEVEL/horde/framework/Core/lib/Horde/Registry.php:1139
3. Nag_Application->download()"

Error from horde.log:
2012-10-29T12:49:05+01:00 EMERG: HORDE [horde] There were no tasks to 
export. [pid 18721 on line 360 of 
"/datastore/DEVEL/horde/nag/lib/Application.php"]


Cheers,
Thomas

Saved Queries