Summary | postgres compatibility for sesha/lib/Driver/Rdo.php when adding properties |
Queue | Sesha |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | ralf.lang (at) ralf-lang (dot) de |
Requester | ralf.lang (at) ralf-lang (dot) de |
Created | 10/25/2012 (4609 days ago) |
Due | |
Updated | 11/28/2012 (4575 days ago) |
Assigned | |
Resolved | 11/28/2012 (4575 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | 1.0.0beta2 |
Patch | Yes |
commit a93f51abc4f6b9d99027b1b9ef57cf5dea6b418e
Author: Ralf Lang <lang@b1-systems.de>
Date: Wed Nov 28 14:54:54 2012 +0200
Patch by PUNkER fixes [#11574] postgres compatibility for
sesha/lib/Driver/Rdo.php when adding properties.
sesha/lib/Driver/Rdo.php | 3 +++
sesha/lib/Entity/PropertyMapper.php | 3 +++
2 files changed, 6 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/a93f51abc4f6b9d99027b1b9ef57cf5dea6b418e
New Attachment: sesha.patch
Priority ⇒ 1. Low
Patch ⇒ Yes
Milestone ⇒
Assigned to Ralf Lang
Queue ⇒ Sesha
Summary ⇒ postgres compatibility for sesha/lib/Driver/Rdo.php when adding properties
Type ⇒ Bug
State ⇒ Assigned
with Postres, it don't create properties and categories throwing sql
error
(10:20:46) PUNkER: because it's trying to insert NULL in property_id
which is NOT NULL
(10:20:56) PUNkER: constraint
(10:33:24) blackcat73 [~Blackcat@adonis.iportalmais.pt] hat den Raum betreten.
(10:35:52) lang-b1s: PUNkER: which version of sesha are you testing?
(10:37:35) PUNkER: lang-b1s: latest from pear
(10:37:42) PUNkER: 1.0.0beta1
(10:38:38) lang-b1s: PUNkER: this version won't run against the latest
horde - against which version are you testing this?
(10:39:08) PUNkER: yeah, it's not beta1 =)
(10:39:30) PUNkER: actually i just cloned git repository and made a
package and then installed by pera
(10:39:38) PUNkER: pera= pear
(10:40:28) lang-b1s: great. can you please show me the structure of
the sesha tables in postgres? do they have an autoincrement?
(10:40:39) PUNkER: yes
(10:41:04) PUNkER: property_id | integer | NOT NULL
DEFAULT nextval('sesha_properties_property_id_seq'::regclass)
(10:41:04) PUNkER: property | character varying(256) |
(10:41:04) PUNkER: datatype | character varying(128) | NOT NULL DEFAULT 0
(10:41:04) PUNkER: parameters | text |
(10:41:04) PUNkER: unit | character varying(32) |
(10:41:06) PUNkER: description | text |
(10:41:08) PUNkER: priority | integer | NOT NULL DEFAULT 0
(10:42:12) PUNkER: but it's not possible to explicitly insert NULL in
property_id
(10:42:22) PUNkER: as backend does
(10:43:04) PUNkER: i little modified php classes but i'm not sure it's
right by design
(10:43:39) lang-b1s: PUNkER: I'm very interested in your
modifications. where did you make changes? Db? Rdo? The Driver_Rdo ?
(10:46:29) PUNkER: lib/Driver/Rdo.php - addCategory($info)
(10:46:53) PUNkER: lib/Entity/PropertyMapper.php - create(array $property)
(10:47:09) PUNkER: if(array_key_exists('property_id', $property)
(10:47:09) PUNkER: && $property['property_id'] == null)
(10:47:09) PUNkER: unset($property['property_id']);
(10:47:39) PUNkER: same thing in Rdo.php
(10:51:01) lang-b1s: can you create a ticket and apply a patch? I'd
review the changes.
(10:51:18) lang-b1s: thank you so far...
(10:56:40) PUNkER: ok, i'll do in near time
(10:57:58) PUNkER: can i also create tickets with enhancement suggestions ?
(11:06:58) PUNkER: <lang-b1s>, can you please tell me what 'Unit'
field of property stand for ?
(11:15:32) lang-b1s: enhancements probably won't go into the version
released now but implemented later
(11:16:18) lang-b1s: unit is the field where you can say how the item
is measured. hardware is in pieces, liquids in volume (liters etc),
sand is in kilogramms etc
(11:35:43) PUNkER: ah, thnx
(11:43:49) lang-b1s: in other words, yes, create enhancement tickets,
but the focus of the current beta is "first release as is, bugfixed"
(12:22:29) PUNkER: ok, i understood
Punker has provided a preliminary patch