Summary | Embedding calendars broken |
Queue | Kronolith |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 3. High |
Owners | mrubinsk (at) horde (dot) org, slusarz (at) horde (dot) org |
Requester | mrubinsk (at) horde (dot) org |
Created | 10/17/2012 (4644 days ago) |
Due | |
Updated | 03/28/2013 (4482 days ago) |
Assigned | |
Resolved | 10/17/2012 (4644 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | 4 |
Patch | No |
commit 2884204d9b175d8729c1e662ba53cbeb9c03e7e6
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Mar 28 11:58:10 2013 -0600
[mms] SECURITY: Fix token validation of AJAX actions.
Mea culpa. This commit broke things:
commit 83dcfa1448ba2b142623839aee78a2160eb25cb0
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Oct 17 13:27:10 2012 -0600
[mms] Allow AJAX handler methods to be marked externally accessible
(i.e. no session token checking) (
Bug #11538).This commit failed to extend the injector to pass the token argument to
the AJAX Application handler. Although we should always do this check,
regardless of whether the token is empty anyway.
framework/Core/lib/Horde/Core/Ajax/Application.php | 5 ++---
framework/Core/lib/Horde/Core/Factory/Ajax.php | 5 +++--
framework/Core/package.xml | 2 ++
3 files changed, 7 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/2884204d9b175d8729c1e662ba53cbeb9c03e7e6
commit d34e93dd8aba2e0d4855a2c1e46569801f4b91f8
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Wed Oct 17 15:55:16 2012 -0400
Allow the embed method to be called without a token.
Final bit of
Bug: 11538kronolith/lib/Ajax/Application/Handler.php | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/d34e93dd8aba2e0d4855a2c1e46569801f4b91f8
commit 83dcfa1448ba2b142623839aee78a2160eb25cb0
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Oct 17 13:27:10 2012 -0600
[mms] Allow AJAX handler methods to be marked externally
accessible (i.e. no session token checking) (
Bug #11538).framework/Core/lib/Horde/Core/Ajax/Application.php | 20
+++++++++++++++++---
.../lib/Horde/Core/Ajax/Application/Handler.php | 20
++++++++++++++++++++
framework/Core/package.xml | 2 ++
horde/services/ajax.php | 13 ++++++-------
4 files changed, 45 insertions(+), 10 deletions(-)
http://git.horde.org/horde-git/-/commit/83dcfa1448ba2b142623839aee78a2160eb25cb0
commit 7f2d0403cbe97f528f9adb2b14cd4a47e2f9a24f
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Wed Oct 17 11:51:46 2012 -0400
$container is already quoted by the serialization.
Partial fix for
Bug: 11538kronolith/lib/Ajax/Application/Handler.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/7f2d0403cbe97f528f9adb2b14cd4a47e2f9a24f
commit d2531c6925c0572b5b93eeb1e7cf08989754c284
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Wed Oct 17 11:17:38 2012 -0400
There is no Horde_Core_Ajax_Response_Javascript.
Use raw output with proper content type. Partial fix for
Bug: 11538kronolith/lib/Ajax/Application/Handler.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/d2531c6925c0572b5b93eeb1e7cf08989754c284
commit d34e93dd8aba2e0d4855a2c1e46569801f4b91f8
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Wed Oct 17 15:55:16 2012 -0400
Allow the embed method to be called without a token.
Final bit of
Bug: 11538kronolith/lib/Ajax/Application/Handler.php | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/d34e93dd8aba2e0d4855a2c1e46569801f4b91f8
in the _external() array in the AJAX Handler. Make sure that these
externally marked AJAX methods are not accessed internally, or else
you defeat the whole purpose of the token checking.
commit 83dcfa1448ba2b142623839aee78a2160eb25cb0
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Oct 17 13:27:10 2012 -0600
[mms] Allow AJAX handler methods to be marked externally
accessible (i.e. no session token checking) (
Bug #11538).framework/Core/lib/Horde/Core/Ajax/Application.php | 20
+++++++++++++++++---
.../lib/Horde/Core/Ajax/Application/Handler.php | 20
++++++++++++++++++++
framework/Core/package.xml | 2 ++
horde/services/ajax.php | 13 ++++++-------
4 files changed, 45 insertions(+), 10 deletions(-)
http://git.horde.org/horde-git/-/commit/83dcfa1448ba2b142623839aee78a2160eb25cb0
commit 7f2d0403cbe97f528f9adb2b14cd4a47e2f9a24f
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Wed Oct 17 11:51:46 2012 -0400
$container is already quoted by the serialization.
Partial fix for
Bug: 11538kronolith/lib/Ajax/Application/Handler.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/7f2d0403cbe97f528f9adb2b14cd4a47e2f9a24f
Priority ⇒ 3. High
Assigned to Michael Slusarz
require a valid token. The token validity depends on the token still
being in the session. (One of) the problems here is that the URL for
embedding the content is generated inside a user's valid session, but
the content will most likely be viewed outside of ANY authenticated
session, let alone the same session the URL was generated in.
Bringing Michael S. in on this since he made the token requirement changes.
commit d2531c6925c0572b5b93eeb1e7cf08989754c284
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Wed Oct 17 11:17:38 2012 -0400
There is no Horde_Core_Ajax_Response_Javascript.
Use raw output with proper content type. Partial fix for
Bug: 11538kronolith/lib/Ajax/Application/Handler.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/d2531c6925c0572b5b93eeb1e7cf08989754c284
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒ 4
Assigned to Michael Rubinsky
Queue ⇒ Kronolith
Summary ⇒ Embedding calendars broken
Type ⇒ Bug
Priority ⇒ 2. Medium