6.0.0-beta1
7/14/25

[#11530] Invalid s/mime cert leads to crash
Summary Invalid s/mime cert leads to crash
Queue Turba
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 10/17/2012 (4653 days ago)
Due
Updated 10/27/2012 (4643 days ago)
Assigned
Resolved 10/17/2012 (4653 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
10/27/2012 12:56:24 AM Git Commit Comment #10 Reply to this comment
Changes have been made in Git (develop):

commit 3bb600de48ef23292e59e8bf33455c83f8e442eb
Author: Jan Schneider <jan@horde.org>
Date:   Wed Oct 17 14:41:12 2012 +0200

     [jan] Catch exceptions from Horde_Crypt (Bug #11530).

  .../Core/lib/Horde/Core/Ui/VarRenderer/Html.php    |    9 ++++++++-
  framework/Core/package.xml                         |    2 ++
  2 files changed, 10 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/3bb600de48ef23292e59e8bf33455c83f8e442eb
10/27/2012 12:56:20 AM Git Commit Comment #9 Reply to this comment
Changes have been made in Git (develop):

commit 0c9032084dcd1a9e0490a9a6af3557376541a326
Author: Jan Schneider <jan@horde.org>
Date:   Wed Oct 17 14:40:39 2012 +0200

     [jan] Throw exception if parsing of S/MIME certificates fails 
(Bug #11530).

  framework/Crypt/lib/Horde/Crypt/Smime.php |    3 +++
  framework/Crypt/package.xml               |    4 ++--
  2 files changed, 5 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/0c9032084dcd1a9e0490a9a6af3557376541a326
10/23/2012 07:55:16 PM Michael Slusarz Comment #8 Reply to this comment
Thanks.
10/23/2012 04:10:06 PM Jan Schneider Comment #7 Reply to this comment
It's technical a BC break because we throw an exception where we 
didn't before, but this is not different from letting DateTime throw 
an exception that we don't catch, so I merged it.
10/23/2012 04:09:17 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (FRAMEWORK_4):

commit a4de0d9e61b75d416ce0992e9235dcad2413e26e
Author: Jan Schneider <jan@horde.org>
Date:   Wed Oct 17 14:41:12 2012 +0200

     [jan] Catch exceptions from Horde_Crypt (Bug #11530).

     Conflicts:

             framework/Core/package.xml

  .../Core/lib/Horde/Core/Ui/VarRenderer/Html.php    |    9 ++++++++-
  framework/Core/package.xml                         |    2 ++
  2 files changed, 10 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/a4de0d9e61b75d416ce0992e9235dcad2413e26e
10/23/2012 04:09:12 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (FRAMEWORK_4):

commit 2aaf8a963b262663115fe04969a0ca6a17025b6f
Author: Jan Schneider <jan@horde.org>
Date:   Wed Oct 17 14:40:39 2012 +0200

     [jan] Throw exception if parsing of S/MIME certificates fails 
(Bug #11530).

     Conflicts:

             framework/Crypt/package.xml

  framework/Crypt/lib/Horde/Crypt/Smime.php |    3 +++
  framework/Crypt/package.xml               |    2 ++
  2 files changed, 5 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/2aaf8a963b262663115fe04969a0ca6a17025b6f
10/22/2012 07:26:24 PM Michael Slusarz Comment #4 Reply to this comment
Any reason this can't/shouldn't be backported to FRAMEWORK_4?
10/17/2012 12:41:40 PM Jan Schneider State ⇒ Resolved
Assigned to Jan Schneider
 
10/17/2012 12:41:36 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 3bb600de48ef23292e59e8bf33455c83f8e442eb
Author: Jan Schneider <jan@horde.org>
Date:   Wed Oct 17 14:41:12 2012 +0200

     [jan] Catch exceptions from Horde_Crypt (Bug #11530).

  .../Core/lib/Horde/Core/Ui/VarRenderer/Html.php    |    9 ++++++++-
  framework/Core/package.xml                         |    2 ++
  2 files changed, 10 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/3bb600de48ef23292e59e8bf33455c83f8e442eb
10/17/2012 12:41:30 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 0c9032084dcd1a9e0490a9a6af3557376541a326
Author: Jan Schneider <jan@horde.org>
Date:   Wed Oct 17 14:40:39 2012 +0200

     [jan] Throw exception if parsing of S/MIME certificates fails 
(Bug #11530).

  framework/Crypt/lib/Horde/Crypt/Smime.php |    3 +++
  framework/Crypt/package.xml               |    4 ++--
  2 files changed, 5 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/0c9032084dcd1a9e0490a9a6af3557376541a326
10/17/2012 08:03:26 AM Thomas Jarosch Comment #1
Milestone ⇒
State ⇒ Unconfirmed
Patch ⇒ No
Queue ⇒ Turba
Summary ⇒ Invalid s/mime cert leads to crash
Type ⇒ Bug
Priority ⇒ 1. Low
Reply to this comment
Hi,

when you create a new contact and enter garbage in the s/mime field,
turba gives you (partly) the blank page of death. Logged error:

2012-10-17T10:00:44+02:00 EMERG: HORDE [turba] DateTime::__construct() 
[<a href='datetime.--construct'>datetime.--construct</a>]: Failed to 
parse time string (@) at position 0 (@): Unexpected character [pid 
15656 on line 557 of 
"/datastore/DEVEL/horde/framework/Crypt/lib/Horde/Crypt/Smime.php"]

Cheers,
Thomas

Saved Queries