6.0.0-RC7
6/23/26

[#11520] Shift-click selecting too many rows
Summary Shift-click selecting too many rows
Queue IMP
Queue Version Git master
Type Bug
State Resolved
Priority 2. Medium
Owners slusarz (at) horde (dot) org
Requester jan (at) horde (dot) org
Created 10/15/12 (4999 days ago)
Due
Updated 11/7/12 (4976 days ago)
Assigned 10/16/12 (4998 days ago)
Resolved 10/25/12 (4989 days ago)
Github Issue Link
Github Pull Request
Milestone 6
Patch No

History
477 Michael Slusarz Comment #11 Reply to this comment
Think I figured this out.  The original/pivot rows were being stored 
at the page level rather than the view level - so switching between 
views with selected messages could cause incorrect selections.

Solution was to store original/pivot rows within a view's metadata.
457 Git Commit Comment #10 Reply to this comment
Changes have been made in Git (master):

commit 331edcbbb5967eff37e6d18f95b6802616d389c4
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Wed Nov 7 00:31:28 2012 -0700

     [mms] Fix shift-clicking in dynamic mailbox view when navigating 
to other mailboxes (Bug #11520).

  imp/docs/CHANGES   |    2 ++
  imp/js/dimpbase.js |   23 ++++++++++++++---------
  imp/package.xml    |    2 ++
  3 files changed, 18 insertions(+), 9 deletions(-)

http://git.horde.org/horde-git/-/commit/331edcbbb5967eff37e6d18f95b6802616d389c4
2512 Git Commit Comment #9 Reply to this comment
Changes have been made in Git (develop):

commit 5818bd18f879cf2a2dee5bc300c1d0314be788c5
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Tue Oct 16 00:42:48 2012 -0600

     Bug #11520: Fix slice range

  imp/js/viewport.js |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/5818bd18f879cf2a2dee5bc300c1d0314be788c5
267 Jan Schneider Comment #8
State ⇒ Resolved
Reply to this comment
I haven't seen this in a few days either, it might be fixed.
379 Michael Slusarz Comment #7
Milestone ⇒ 6
Reply to this comment
Setting correct milestone.
439 Michael Slusarz Comment #6
Priority ⇒ 2. Medium
Milestone ⇒ 5
Reply to this comment
Ping?

Setting IMP 6 milestone.  Downgrading priority since I cannot reproduce.
486 Michael Slusarz Comment #5
State ⇒ Feedback
Reply to this comment
I cannot replicate your issue - at least with the incorrect amount of 
messages selected.  I *was* able to replicate some strange behavior 
where the shift-click message was not included in the eventual 
selection (the actual selection ended a few messages before the 
clicked message).  This has been fixed - not sure if this is related 
to what you are experiencing.
136 Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit 5818bd18f879cf2a2dee5bc300c1d0314be788c5
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Tue Oct 16 00:42:48 2012 -0600

     Bug #11520: Fix slice range

  imp/js/viewport.js |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/5818bd18f879cf2a2dee5bc300c1d0314be788c5
1910 Jan Schneider Comment #3 Reply to this comment
It seems to work fine if all rows are cached in the browser already, 
so the additional viewPort requests might be the key.
4510 Jan Schneider Comment #2 Reply to this comment
High prio because I accidentally flagged and deleted most of one of my 
mailboxes without noticing.
5110 Jan Schneider Comment #1
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒
Assigned to Michael Slusarz
Queue ⇒ IMP
Summary ⇒ Shift-click selecting too many rows
Type ⇒ Bug
Priority ⇒ 3. High
Reply to this comment
If I click a message in a large mailbox, then click-scroll several 
pages further, so far that new slices are loaded from the backend, and 
then shift click another message, there are far too many messages 
selected. Like 12000 instead of 200.

Saved Queries