Tickets :: [#11478] Virtual Trash Broken

6.0.0-beta1

9/2/25

Summary	Virtual Trash Broken
Queue	IMP
Queue Version	5.0.23
Type	Bug
State	Resolved
Priority	2. Medium
Owners	slusarz (at) horde (dot) org
Requester	tonyb (at) go-concepts (dot) com
Created	10/08/2012 (4712 days ago)
Due
Updated	10/15/2012 (4705 days ago)
Assigned
Resolved	10/08/2012 (4712 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

10/15/2012 08:43:56 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (develop): commit 8f955fe5d16547a31743bd5713d20a05e72a39a4 Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Oct 8 14:23:17 2012 -0600 [mms] Fix regression in using Virtual Trash (~~Bug #11478~~; tonyb@go-concepts.com). Conflicts: imp/lib/Mailbox.php imp/package.xml imp/docs/CHANGES \| 2 ++ imp/lib/Mailbox.php \| 2 +- imp/lib/Message.php \| 8 ++++---- imp/package.xml \| 1 + 4 files changed, 8 insertions(+), 5 deletions(-) http://git.horde.org/horde-git/-/commit/8f955fe5d16547a31743bd5713d20a05e72a39a4

10/08/2012 08:28:24 PM	Michael Slusarz	Comment #4 Assigned to Michael Slusarz State ⇒ Resolved	Reply to this comment
There is a typo in imp/lib/Mailbox.php causing issue #2 and I think there is a logic error in imp/lib/Message.php causing the first issue. Fixed in 5.0.24. The fix in Message.php was changed from the original patch (your version would cause anyone using a non-virtual trash mailbox to have messages always immediately expunged; correct logic is to skip expunging for virtual trash but go through other 3 checks if this is a regular trash mailbox).

10/08/2012 08:26:08 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (master): commit 8f955fe5d16547a31743bd5713d20a05e72a39a4 Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Oct 8 14:23:17 2012 -0600 [mms] Fix regression in using Virtual Trash (~~Bug #11478~~; tonyb@go-concepts.com). Conflicts: imp/lib/Mailbox.php imp/package.xml imp/docs/CHANGES \| 2 ++ imp/lib/Mailbox.php \| 2 +- imp/lib/Message.php \| 8 ++++---- imp/package.xml \| 1 + 4 files changed, 8 insertions(+), 5 deletions(-) http://git.horde.org/horde-git/-/commit/8f955fe5d16547a31743bd5713d20a05e72a39a4

10/08/2012 08:23:48 PM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (FRAMEWORK_4): commit f60046c18c75b1cde5c8ac57f917b59d024cfe49 Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Oct 8 14:23:17 2012 -0600 [mms] Fix regression in using Virtual Trash (~~Bug #11478~~; tonyb@go-concepts.com). imp/docs/CHANGES \| 2 ++ imp/lib/Mailbox.php \| 2 +- imp/lib/Message.php \| 8 ++++---- imp/package.xml \| 2 ++ 4 files changed, 9 insertions(+), 5 deletions(-) http://git.horde.org/horde-git/-/commit/f60046c18c75b1cde5c8ac57f917b59d024cfe49

10/08/2012 07:54:24 PM	tonyb (at) go-concepts (dot) com	Comment #1 Priority ⇒ 2. Medium New Attachment: imp-vtrash.patch Patch ⇒ Yes Milestone ⇒ Summary ⇒ Virtual Trash Broken Type ⇒ Bug State ⇒ Unconfirmed Queue ⇒ IMP	Reply to this comment
Virtual trash appears to be broken in IMP v5 (and in master branch from github). There are two main issues I have discovered: 1 - With vtrash enabled messages were being purged immediately via IMAP instead of being marked as deleted 2 - Once issue 1 was resolved messages were marked as deleted but they were being shown in their original folder and the Virtual trash was empty. There is a typo in imp/lib/Mailbox.php causing issue #2 and I think there is a logic error in imp/lib/Message.php causing the first issue. Attached is a patch against 5.0.23 (also available here: https://gist.github.com/3835398) and I will submit a pull request against master at github.