6.0.0-beta1
8/11/25

[#11471] NO reponse not correctly parsed.
Summary NO reponse not correctly parsed.
Queue Horde Framework Packages
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester jan (at) horde (dot) org
Created 10/08/2012 (4690 days ago)
Due
Updated 10/15/2012 (4683 days ago)
Assigned
Resolved 10/08/2012 (4690 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
10/15/2012 08:43:41 PM Git Commit Comment #7 Reply to this comment
Changes have been made in Git (develop):

commit 7be38af2d4c2fe6fcf087bfd786bd1e2d1fd36be
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Oct 8 12:15:00 2012 -0600

     Bug #11471: Correctly grab the command that caused the tagged 
NO/BAD response

  .../lib/Horde/Imap/Client/Interaction/Client.php   |   12 ++++++++++++
  .../Imap_Client/lib/Horde/Imap/Client/Socket.php   |   15 +++++----------
  2 files changed, 17 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/7be38af2d4c2fe6fcf087bfd786bd1e2d1fd36be
10/15/2012 08:43:37 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (develop):

commit 69ba0b26d2a06cc87e79dd9afdb43e7761a8ef3d
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Oct 8 12:06:03 2012 -0600

     Revert "BAD and NO responses don't contain the original command 
(Bug #11471)."

     This reverts commit c59bf1806b170540953fb3b45d565f93574240df.

  .../Imap_Client/lib/Horde/Imap/Client/Socket.php   |   16 ++++++++++++++--
  1 files changed, 14 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/69ba0b26d2a06cc87e79dd9afdb43e7761a8ef3d
10/15/2012 08:43:05 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (develop):

commit c59bf1806b170540953fb3b45d565f93574240df
Author: Jan Schneider <jan@horde.org>
Date:   Mon Oct 8 13:30:24 2012 +0200

     BAD and NO responses don't contain the original command (Bug #11471).

     As per RFC 3501 7.1.2 and 7.1.3 (and Cyrus' actual behaviour), 
tagged responses
     only indicate that the error response links to a command. This command is
     identified by the tag, not by the response message.

  .../Imap_Client/lib/Horde/Imap/Client/Socket.php   |   16 ++--------------
  1 files changed, 2 insertions(+), 14 deletions(-)

http://git.horde.org/horde-git/-/commit/c59bf1806b170540953fb3b45d565f93574240df
10/08/2012 06:20:00 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit 7be38af2d4c2fe6fcf087bfd786bd1e2d1fd36be
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Oct 8 12:15:00 2012 -0600

     Bug #11471: Correctly grab the command that caused the tagged 
NO/BAD response

  .../lib/Horde/Imap/Client/Interaction/Client.php   |   12 ++++++++++++
  .../Imap_Client/lib/Horde/Imap/Client/Socket.php   |   15 +++++----------
  2 files changed, 17 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/7be38af2d4c2fe6fcf087bfd786bd1e2d1fd36be
10/08/2012 06:19:56 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 69ba0b26d2a06cc87e79dd9afdb43e7761a8ef3d
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Oct 8 12:06:03 2012 -0600

     Revert "BAD and NO responses don't contain the original command 
(Bug #11471)."

     This reverts commit c59bf1806b170540953fb3b45d565f93574240df.

  .../Imap_Client/lib/Horde/Imap/Client/Socket.php   |   16 ++++++++++++++--
  1 files changed, 14 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/69ba0b26d2a06cc87e79dd9afdb43e7761a8ef3d
10/08/2012 11:54:29 AM Jan Schneider Assigned to Jan Schneider
State ⇒ Resolved
 
10/08/2012 11:54:19 AM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit c59bf1806b170540953fb3b45d565f93574240df
Author: Jan Schneider <jan@horde.org>
Date:   Mon Oct 8 13:30:24 2012 +0200

     BAD and NO responses don't contain the original command (Bug #11471).

     As per RFC 3501 7.1.2 and 7.1.3 (and Cyrus' actual behaviour), 
tagged responses
     only indicate that the error response links to a command. This command is
     identified by the tag, not by the response message.

  .../Imap_Client/lib/Horde/Imap/Client/Socket.php   |   16 ++--------------
  1 files changed, 2 insertions(+), 14 deletions(-)

http://git.horde.org/horde-git/-/commit/c59bf1806b170540953fb3b45d565f93574240df
10/08/2012 11:19:57 AM Jan Schneider Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ NO reponse not correctly parsed.
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
If getting a NO response like this:

C: 11 CREATE "INBOX.Test"
S: 11 NO Mailbox already exists

The NO handler in _getLine() strips of the first token "Mailbox" as 
the command into $cmd.

Saved Queries