6.0.0-beta1
9/2/25

[#11470] Inconsistent handling of commas in tags
Summary Inconsistent handling of commas in tags
Queue Horde Base
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester jan (at) horde (dot) org
Created 10/08/2012 (4712 days ago)
Due
Updated 10/15/2012 (4705 days ago)
Assigned
Resolved 10/12/2012 (4708 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
10/15/2012 08:45:42 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (develop):

commit 5ce8c40f1e1634fa4807659c7191ab55798b86c3
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Fri Oct 12 09:17:14 2012 -0400

     Use a simple split on commas for tags.

     Bug: 11470

  framework/Core/lib/Horde/Core/Tagger.php |    9 ++++++---
  1 files changed, 6 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/5ce8c40f1e1634fa4807659c7191ab55798b86c3
10/12/2012 01:18:33 PM Michael Rubinsky State ⇒ Resolved
 
10/12/2012 01:18:14 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 5ce8c40f1e1634fa4807659c7191ab55798b86c3
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Fri Oct 12 09:17:14 2012 -0400

     Use a simple split on commas for tags.

     Bug: 11470

  framework/Core/lib/Horde/Core/Tagger.php |    9 ++++++---
  1 files changed, 6 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/5ce8c40f1e1634fa4807659c7191ab55798b86c3
10/09/2012 01:57:45 PM Michael Rubinsky Comment #2 Reply to this comment
I'd be in favor of removing support for these complicated tag strings 
too.  Chuck original included support for this in the original content 
tagger code (in Content_Tagger::split()). Not sure I want to remove 
that code there, but rather override that method in Horde_Core_Tagger, 
so other users of the code can make the decision for themselves...
10/08/2012 10:33:01 AM Jan Schneider Comment #1
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Assigned to Michael Rubinsky
Queue ⇒ Horde Base
Summary ⇒ Inconsistent handling of commas in tags
Type ⇒ Bug
State ⇒ Assigned
Reply to this comment
Noticed in Kronolith but probably applies to other tag-enabled 
applications too:
In traditional view, I can create tags including commas by surrounding 
the tags with double quotes. When displaying or editing the tags, the 
quotes are missing though.
On the other hand, the tags are displayed correctly in dynamic view 
(without quotes, but complete tag including commas inside the tag 
label), but they can't be added, because a new tag is created as soon 
as you enter comma, even if you have an open double quote.

Not sure if we want to allow commas inside tags at all, but we should 
consistently allow (and support), or deny them.

Saved Queries