6.0.0-beta1
7/19/25

[#11465] Using third-party Driver causes php error
Summary Using third-party Driver causes php error
Queue Sam
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester Nathaniel.Clark (at) misrule (dot) us
Created 10/04/2012 (4671 days ago)
Due
Updated 10/15/2012 (4660 days ago)
Assigned
Resolved 10/08/2012 (4667 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
10/15/2012 08:43:11 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (develop):

commit acd2635b556e84b791976430c4cdd4384f9e4f64
Author: Jan Schneider <jan@horde.org>
Date:   Mon Oct 8 15:03:59 2012 +0200

     Support parameters for custom drivers (Request #11465).

  sam/lib/Factory/Driver.php |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/acd2635b556e84b791976430c4cdd4384f9e4f64
10/08/2012 01:04:29 PM Jan Schneider Assigned to Jan Schneider
State ⇒ Resolved
 
10/08/2012 01:04:17 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit acd2635b556e84b791976430c4cdd4384f9e4f64
Author: Jan Schneider <jan@horde.org>
Date:   Mon Oct 8 15:03:59 2012 +0200

     Support parameters for custom drivers (Request #11465).

  sam/lib/Factory/Driver.php |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/acd2635b556e84b791976430c4cdd4384f9e4f64
10/04/2012 09:56:46 PM Nathaniel (dot) Clark (at) misrule (dot) us Comment #1
Priority ⇒ 1. Low
New Attachment: sam-factory.patch Download
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Sam
Summary ⇒ Using third-party Driver causes php error
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
In sam/lib/Factory/Driver.php Sam_Factory_Driver::create() all the 
Drivers are listed in a switch statement.  If a third-party driver is 
added then a variable params is left undefined and causes sam to fail 
to run at all.  This adds a default to the switch statement that just 
passes the params defined in the config file to the driver.

Saved Queries