| Summary | CRAM-MD5 broken for imap |
| Queue | Horde Framework Packages |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 2. Medium |
| Owners | slusarz (at) horde (dot) org |
| Requester | patrickdk (at) patrickdk (dot) com |
| Created | 09/25/2012 (4689 days ago) |
| Due | |
| Updated | 10/27/2012 (4657 days ago) |
| Assigned | 09/25/2012 (4689 days ago) |
| Resolved | 09/26/2012 (4688 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
commit 41f4c42004023fa7929c9dd1fd5b5a96018ddd83
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Oct 25 01:12:23 2012 -0600
[mms] Fix CRAM-MD5 authentication for POP3 driver (
Bug #11449).Conflicts:
framework/Imap_Client/package.xml
.../lib/Horde/Imap/Client/Socket/Pop3.php | 6 ++++--
framework/Imap_Client/package.xml | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/41f4c42004023fa7929c9dd1fd5b5a96018ddd83
commit 6d584d6645181b097d1abed69ee997cce9075837
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Oct 25 01:12:23 2012 -0600
[mms] Fix CRAM-MD5 authentication for POP3 driver (
Bug #11449)..../lib/Horde/Imap/Client/Socket/Pop3.php | 6 ++++--
framework/Imap_Client/package.xml | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/6d584d6645181b097d1abed69ee997cce9075837
commit 3c3e0814c3f67e1f546f03ff1e3ad695e61320c0
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Sep 27 12:55:19 2012 -0600
Bug #11449: Ugh - another typo.../Imap_Client/lib/Horde/Imap/Client/Socket.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/3c3e0814c3f67e1f546f03ff1e3ad695e61320c0
commit afa70168b7cddb0b1ffa2f3109691ce468b95583
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Sep 26 11:59:29 2012 -0600
[mms] Fix CRAM-MD5 authentication (
Bug #11449; patrickdk@patrickdk.com).Conflicts:
framework/Imap_Client/lib/Horde/Imap/Client/Socket.php
framework/Imap_Client/package.xml
.../Imap_Client/lib/Horde/Imap/Client/Socket.php | 3 +--
framework/Imap_Client/package.xml | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/afa70168b7cddb0b1ffa2f3109691ce468b95583
commit 3c3e0814c3f67e1f546f03ff1e3ad695e61320c0
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Sep 27 12:55:19 2012 -0600
Bug #11449: Ugh - another typo.../Imap_Client/lib/Horde/Imap/Client/Socket.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/3c3e0814c3f67e1f546f03ff1e3ad695e61320c0
State ⇒ Resolved
commit 912ca2ff700283091aa0e86fb90931b14c0f7e8e
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Sep 26 12:04:10 2012 -0600
Bug #11449: Missed this change..../Imap_Client/lib/Horde/Imap/Client/Socket.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/912ca2ff700283091aa0e86fb90931b14c0f7e8e
commit afa70168b7cddb0b1ffa2f3109691ce468b95583
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Sep 26 11:59:29 2012 -0600
[mms] Fix CRAM-MD5 authentication (
Bug #11449; patrickdk@patrickdk.com).Conflicts:
framework/Imap_Client/lib/Horde/Imap/Client/Socket.php
framework/Imap_Client/package.xml
.../Imap_Client/lib/Horde/Imap/Client/Socket.php | 3 +--
framework/Imap_Client/package.xml | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/afa70168b7cddb0b1ffa2f3109691ce468b95583
commit c085be7ddf911f1761746957e6e058e856ffcda5
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Sep 26 11:59:29 2012 -0600
[mms] Fix CRAM-MD5 authentication (
Bug #11449; patrickdk@patrickdk.com)..../Imap_Client/lib/Horde/Imap/Client/Socket.php | 2 +-
framework/Imap_Client/package.xml | 2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/c085be7ddf911f1761746957e6e058e856ffcda5
State ⇒ Assigned
Priority ⇒ 2. Medium
State ⇒ Unconfirmed
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ CRAM-MD5 broken for imap
Type ⇒ Bug
Priority ⇒ 3. High
Tested CRAM-MD5 logins now work, and also manually verified calculated
results.
From 2944c3dd0ffd2686d862d90a16f58124ec7c98d1 Mon Sep 17 00:00:00 2001
From: Patrick Domack <patrickdk@patrickdk.com>
Date: Tue, 25 Sep 2012 14:16:17 -0400
Subject: [PATCH] Fix CRAM-MD5 auth
---
.../Imap_Client/lib/Horde/Imap/Client/Socket.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/Imap_Client/lib/Horde/Imap/Client/Socket.php
b/framework/Imap_Client/lib/Horde/Imap/Client/Socket.php
index d88ed7d..3febe49 100644
--- a/framework/Imap_Client/lib/Horde/Imap/Client/Socket.php
+++ b/framework/Imap_Client/lib/Horde/Imap/Client/Socket.php
@@ -570,7 +570,7 @@ class Horde_Imap_Client_Socket extends
Horde_Imap_Client_Base
$cmd = new Horde_Imap_Client_Data_Format_List(
- base64_encode($this->_params['username'] . ' ' .
hash_hmac(strtolower(substr($method, 5)), $this->getParam('password'),
base64_decode($ob['line']), true))
+ base64_encode($this->_params['username'] . ' ' .
hash_hmac(strtolower(substr($method, 5)), base64_decode($ob['line']),
$this->getParam('password'), false))
);
$this->_sendLine($cmd, array(
'debug' => '[' . $method . ' Response]'
--
1.7.9.5