Tickets :: [#11417] Toggle junk flags

6.0.0-beta1

11/5/25

Summary	Toggle junk flags
Queue	IMP
Queue Version	Git master
Type	Enhancement
State	Rejected
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	09/12/2012 (4802 days ago)
Due
Updated	10/02/2012 (4782 days ago)
Assigned
Resolved	10/02/2012 (4782 days ago)
Milestone	6
Patch	No

10/02/2012 09:19:12 AM	Jan Schneider	Comment #5 State ⇒ Rejected	Reply to this comment
Can no longer reproduce.

10/02/2012 12:30:18 AM	Michael Slusarz	Comment #4 Assigned to Jan Schneider Milestone ⇒ 6	Reply to this comment
Ping?

09/12/2012 07:18:16 PM	Michael Slusarz	Comment #3	Reply to this comment
I can report messages both a spam and ham, and end up with messages having both the $Junk and $NotJunk flags set. This could happen in real life scenarios, if the user accidentally reports a message a spam, and then wants to revert this action by reporting them as not spam. I can't reproduce this - the code in IMP_Spam ensures that only one is set at any given time, e.g.: $imp_message->flag(array('$junk'), $indices, true); $imp_message->flag(array('$notjunk'), $indices, false);

09/12/2012 06:04:48 PM	Michael Slusarz	Comment #2	Reply to this comment
No, these flags should never be settable by the user. These flags have certain semantics that need to be enforced (no different than the $Forwarded flag, for example). You shouldn't be seeing both $Junk and $NotJunk though. If we are not clearing one when flagging with the other, this is a bug.

09/12/2012 09:16:39 AM	Jan Schneider	Priority ⇒ 1. Low State ⇒ Feedback Type ⇒ Enhancement

09/12/2012 09:16:20 AM	Jan Schneider	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Toggle junk flags Queue ⇒ IMP Milestone ⇒ Patch ⇒ No State ⇒ Feedback	Reply to this comment
Should $Junk and $NotJunk flags be a switch? I can report messages both a spam and ham, and end up with messages having both the $Junk and $NotJunk flags set. This could happen in real life scenarios, if the user accidentally reports a message a spam, and then wants to revert this action by reporting them as not spam.