6.0.0-beta1
7/10/25

[#11407] All header link tags in all applications
Summary All header link tags in all applications
Queue Horde Framework Packages
Queue Version Git master
Type Bug
State Resolved
Priority 2. Medium
Owners Horde Developers (at) , jan (at) horde (dot) org, mrubinsk (at) horde (dot) org
Requester jan (at) horde (dot) org
Created 09/05/2012 (4691 days ago)
Due
Updated 10/27/2012 (4639 days ago)
Assigned 09/05/2012 (4691 days ago)
Resolved 10/17/2012 (4649 days ago)
Github Issue Link
Github Pull Request
Milestone 5
Patch No

History
10/27/2012 12:57:48 AM Git Commit Comment #13 Reply to this comment
Changes have been made in Git (develop):

commit c942ce84c28eea0ecb4b92a11a9a053c6d22e7aa
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Wed Oct 17 17:09:45 2012 -0400

     Only output links where we need them.

     Bug: 11407

  whups/lib/Application.php  |   10 +++-------
  whups/lib/Whups.php        |   11 +++++++++++
  whups/mybugs.php           |    2 ++
  whups/query/index.php      |    2 +-
  whups/query/run.php        |    1 +
  whups/queue/index.php      |    1 +
  whups/search.php           |    1 +
  whups/ticket/index.php     |    1 +
  wicked/display.php         |    1 +
  wicked/lib/Application.php |    6 ------
  wicked/lib/Wicked.php      |    9 +++++++++
  11 files changed, 31 insertions(+), 14 deletions(-)

http://git.horde.org/horde-git/-/commit/c942ce84c28eea0ecb4b92a11a9a053c6d22e7aa
10/27/2012 12:54:53 AM Git Commit Comment #12 Reply to this comment
Changes have been made in Git (develop):

commit 9c258a9dfedbbf2400ff633ca638e7c1fc36f8bc
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Oct 13 21:30:05 2012 -0400

     Bug: 11407 Only show feed link when we need to.

  trean/browse.php          |    1 +
  trean/lib/Application.php |   10 ----------
  trean/lib/Trean.php       |   13 +++++++++++++
  trean/search.php          |    1 +
  4 files changed, 15 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/9c258a9dfedbbf2400ff633ca638e7c1fc36f8bc
10/18/2012 11:14:23 PM Git Commit Comment #11 Reply to this comment
Changes have been made in Git (master):

commit 9c258a9dfedbbf2400ff633ca638e7c1fc36f8bc
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Oct 13 21:30:05 2012 -0400

     Bug: 11407 Only show feed link when we need to.

  trean/browse.php          |    1 +
  trean/lib/Application.php |   10 ----------
  trean/lib/Trean.php       |   13 +++++++++++++
  trean/search.php          |    1 +
  4 files changed, 15 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/9c258a9dfedbbf2400ff633ca638e7c1fc36f8bc
10/17/2012 10:05:17 PM Michael Rubinsky Comment #10
Assigned to Jan Schneider
Assigned to Michael Rubinsky
State ⇒ Resolved
Reply to this comment
These should be all gone now.
10/17/2012 10:03:44 PM Git Commit Comment #9 Reply to this comment
Changes have been made in Git (master):

commit c942ce84c28eea0ecb4b92a11a9a053c6d22e7aa
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Wed Oct 17 17:09:45 2012 -0400

     Only output links where we need them.

     Bug: 11407

  whups/lib/Application.php  |   10 +++-------
  whups/lib/Whups.php        |   11 +++++++++++
  whups/mybugs.php           |    2 ++
  whups/query/index.php      |    2 +-
  whups/query/run.php        |    1 +
  whups/queue/index.php      |    1 +
  whups/search.php           |    1 +
  whups/ticket/index.php     |    1 +
  wicked/display.php         |    1 +
  wicked/lib/Application.php |    6 ------
  wicked/lib/Wicked.php      |    9 +++++++++
  11 files changed, 31 insertions(+), 14 deletions(-)

http://git.horde.org/horde-git/-/commit/c942ce84c28eea0ecb4b92a11a9a053c6d22e7aa
10/15/2012 08:46:58 PM Git Commit Comment #8 Reply to this comment
Changes have been made in Git (develop):

commit 43301cf3927f99e981074887ca7512f22b0f7ab1
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Oct 13 21:30:05 2012 -0400

     Bug: 11407 Only show feed link when we need to.

  trean/browse.php          |    1 +
  trean/lib/Application.php |   10 ----------
  trean/lib/Trean.php       |   13 +++++++++++++
  trean/search.php          |    1 +
  4 files changed, 15 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/43301cf3927f99e981074887ca7512f22b0f7ab1
10/15/2012 08:45:34 PM Git Commit Comment #7 Reply to this comment
Changes have been made in Git (develop):

commit 6f704edce0c28ad03541c80ea0ab18732339cbf7
Author: Jan Schneider <jan@horde.org>
Date:   Thu Oct 11 21:15:00 2012 +0200

     Only show feed links where it makes sense (Bug #11407).

  kronolith/day.php             |    1 +
  kronolith/lib/Application.php |    6 ------
  kronolith/lib/Kronolith.php   |   13 +++++++++++++
  kronolith/month.php           |    1 +
  kronolith/week.php            |    1 +
  kronolith/workweek.php        |    1 +
  6 files changed, 17 insertions(+), 6 deletions(-)

http://git.horde.org/horde-git/-/commit/6f704edce0c28ad03541c80ea0ab18732339cbf7
10/14/2012 01:31:01 AM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (master):

commit 43301cf3927f99e981074887ca7512f22b0f7ab1
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Oct 13 21:30:05 2012 -0400

     Bug: 11407 Only show feed link when we need to.

  trean/browse.php          |    1 +
  trean/lib/Application.php |   10 ----------
  trean/lib/Trean.php       |   13 +++++++++++++
  trean/search.php          |    1 +
  4 files changed, 15 insertions(+), 10 deletions(-)

http://git.horde.org/horde-git/-/commit/43301cf3927f99e981074887ca7512f22b0f7ab1
10/11/2012 07:15:23 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (master):

commit 6f704edce0c28ad03541c80ea0ab18732339cbf7
Author: Jan Schneider <jan@horde.org>
Date:   Thu Oct 11 21:15:00 2012 +0200

     Only show feed links where it makes sense (Bug #11407).

  kronolith/day.php             |    1 +
  kronolith/lib/Application.php |    6 ------
  kronolith/lib/Kronolith.php   |   13 +++++++++++++
  kronolith/month.php           |    1 +
  kronolith/week.php            |    1 +
  kronolith/workweek.php        |    1 +
  6 files changed, 17 insertions(+), 6 deletions(-)

http://git.horde.org/horde-git/-/commit/6f704edce0c28ad03541c80ea0ab18732339cbf7
10/09/2012 10:24:23 PM Michael Slusarz Comment #4
Priority ⇒ 2. Medium
Reply to this comment
This needs to be fixed for Kronolith, at a minimum, before we release 
the next major version.
09/05/2012 10:55:49 PM Jan Schneider Comment #3
Milestone ⇒ 5
State ⇒ Assigned
Taken from Michael Slusarz
Assigned to Horde DevelopersHorde Developers
Reply to this comment
I have Kronolith feeds, Trean feeds, Whups opensearch and sometimes 
stuff from Wicked. But it's possible that all those apps do this in 
their _init() methods.
09/05/2012 09:13:18 PM Michael Slusarz Comment #2
State ⇒ Feedback
Reply to this comment
I don't see this.

For example, going to the portal page (where I am displaying an imp, 
turba, nag, and ingo block), I see these link tags:

<!--a75c305b1c0a6022--><link 
href="/horde/imp/themes/default/block/screen.css" rel="stylesheet" 
type="text/css" />
<!--a75c305b1c0a6022--><link 
href="/horde/ingo/themes/default/block/screen.css" rel="stylesheet" 
type="text/css" />
<!--a75c305b1c0a6022--><link 
href="/horde/turba/themes/default/block/screen.css" rel="stylesheet" 
type="text/css" />
<!--a75c305b1c0a6022--><link 
href="/horde/nag/themes/default/screen.css" rel="stylesheet" 
type="text/css" />
<!--a75c305b1c0a6022--><link href="/horde/themes/default/screen.css" 
rel="stylesheet" type="text/css" />
<!--a75c305b1c0a6022--><link href="/horde/themes/default/mozilla.css" 
rel="stylesheet" type="text/css" />
<!--a75c305b1c0a6022--><link 
href="/horde/themes/default/graphics/favicon.ico" rel="SHORTCUT ICON" />
<!--a75c305b1c0a6022--><link rel="alternate" 
type="application/atom+xml" 
href="https://bigworm.curecanti.org/horde/kronolith/feed/index.php?c=slusarz
/>  <title>Horde :: My Portal</title>

Those CSS definitions are all expected, as they are needed to show the 
portal blocks.  The shortcut icon displays the appropriate icon for 
the application that rendered the page (horde).

The kronolith link shouldn't be in there, but this isn't a PageOutput 
issue but rather a problem with the Kronolith app _init() method that 
I have mentioned multiple times previously (there is way too much 
initialization that goes on in there outside of basic app 
initialization; i.e. no browser output elements should ever be put in 
there).  I personally don't know enough about Kronolith's init 
mechanism to be able to move this to somewhere more appropriate (i.e. 
a standardized output method, like IMP::header(), that will queue 
browser output elements only when the application is responsible for 
outputting the page).
09/05/2012 01:09:16 PM Jan Schneider Comment #1
Priority ⇒ 1. Low
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒
Assigned to Michael Slusarz
Queue ⇒ Horde Framework Packages
Summary ⇒ All header link tags in all applications
Type ⇒ Bug
Reply to this comment
After the conversion to PageOutput, the link tags that are added to 
the document header include every link from any application that had 
been pushed during that request.

Saved Queries