| Summary | Kolab storage: Move of objects does not update the cache |
| Queue | Horde Framework Packages |
| Queue Version | Git develop |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | wrobel (at) horde (dot) org |
| Requester | thomas.jarosch (at) intra2net (dot) com |
| Created | 07/21/2012 (4739 days ago) |
| Due | |
| Updated | 11/22/2012 (4615 days ago) |
| Assigned | 08/21/2012 (4708 days ago) |
| Resolved | 11/22/2012 (4615 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
State ⇒ Resolved
commit b93dd25d9d6e4857716e430f7a80e80604179d65
Author: Gunnar Wrobel <p@rdus.de>
Date: Tue Nov 20 09:29:50 2012 +0100
Correct cache update after move.
Bug #11305..../lib/Horde/Kolab/Storage/Data/Base.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/b93dd25d9d6e4857716e430f7a80e80604179d65
The added code in move() looks like this:
--------------------------------------
...
$this->synchronize(
array(
'changes' => array(
Horde_Kolab_Storage_Folder_Stamp::ADDED => array(),
Horde_Kolab_Storage_Folder_Stamp::DELETED =>
array($object_id)
)
)
);
--------------------------------------
Shouldn't it be "Horde_Kolab_Storage_Folder_Stamp::DELETED => array($uid)"?
That's the way the "delete" code a few lines below works.
Still everything seems to work fine, I'm just asking.
commit dbde575d75584f0fe2da3f67f91e13e62f30eebe
Author: Gunnar Wrobel <p@rdus.de>
Date: Tue Aug 21 10:17:58 2012 +0200
Quick fix for the moving issue
#11305..../lib/Horde/Kolab/Storage/Data/Base.php | 8 ++++++++
kronolith/lib/Driver/Kolab.php | 7 +++----
mnemo/lib/Driver/Kolab.php | 1 +
nag/lib/Driver/Kolab.php | 3 ++-
4 files changed, 14 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/dbde575d75584f0fe2da3f67f91e13e62f30eebe
commit dbde575d75584f0fe2da3f67f91e13e62f30eebe
Author: Gunnar Wrobel <p@rdus.de>
Date: Tue Aug 21 10:17:58 2012 +0200
Quick fix for the moving issue
#11305..../lib/Horde/Kolab/Storage/Data/Base.php | 8 ++++++++
kronolith/lib/Driver/Kolab.php | 7 +++----
mnemo/lib/Driver/Kolab.php | 1 +
nag/lib/Driver/Kolab.php | 3 ++-
4 files changed, 14 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/dbde575d75584f0fe2da3f67f91e13e62f30eebe
State ⇒ Assigned
Assigned to Gunnar Wrobel
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Kolab storage: Move of objects does not update the cache
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
moving an object in mnemo or nag is currently broken:
The message is moved on the IMAP server but the horde cache is not updated.
This results in a horde exception once the active application tries to
access it after the move.
Rant of the day:
I've tried for two hours to understand the new code Kolab_Storage code
structure and still don't fully get the details. Compared to Horde 4,
the size/complexity of the Kolab backend increased from 14 php files
to 81 files. Lines of code exploded from 7030 to 18742 (not counting
the unit tests).
I'm also wondering why we need five different IMAP driver
implementations in Kolab_Storage?
Cheers,
Thomas