6.0.0-beta1
7/5/25

[#11251] Blank pages when using popup windows
Summary Blank pages when using popup windows
Queue IMP
Queue Version Git develop
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org, slusarz (at) horde (dot) org
Requester leena.heino (at) uta (dot) fi
Created 07/09/2012 (4744 days ago)
Due
Updated 11/15/2012 (4615 days ago)
Assigned 07/09/2012 (4744 days ago)
Resolved 07/10/2012 (4743 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
11/15/2012 04:57:01 PM bjoern (dot) koester (at) mediata (dot) net Comment #16 Reply to this comment
there seams to be a bug in compose-dimp.js row 1136ff

if (DimpCore.conf.flist) {
             this.createPopdown('sm', {
                 base: 'save_sent_mail',
                 data: DimpCore.conf.flist,
                 input: 'save_sent_mail_mbox',
                 label: 'sent_mail_label'
             });
             this.setPopdownLabel('sm', 
ImpComposeBase.identities[$F('identity')].sm_name);
         }

while uncomment this part, all works fine.


11/15/2012 02:17:08 PM bjoern (dot) koester (at) mediata (dot) net Comment #15 Reply to this comment
I still get a blank page in the dynamic view by using the compose new 
message link. Only the "Loading..." hint is shown. New message sending 
ist not possible.
No js or css error is shown in firebug.


By fowarding or answering to a message the content of the 
forwarded/answered message ist not shown. While sending this mail the 
content is part of the mail.


08/29/2012 12:41:25 PM Git Commit Comment #14 Reply to this comment
Changes have been made in Git (master):

commit d218becb3ae3d69daeaedcef25a229d052ec51b4
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Tue Jul 10 00:19:25 2012 -0600

     Another fix for Bug #11251

  imp/js/compose-dimp.js             |    2 +-
  imp/lib/Dynamic/Compose/Common.php |    6 +++---
  2 files changed, 4 insertions(+), 4 deletions(-)

http://git.horde.org/horde-git/-/commit/d218becb3ae3d69daeaedcef25a229d052ec51b4
08/29/2012 12:41:13 PM Git Commit Comment #13 Reply to this comment
Changes have been made in Git (master):

commit 0d1f5587f8ff1d2ab31bf3191c38fa1f60a214cf
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Jul 9 23:08:41 2012 -0600

     Correctly fix Bug #11251: previous fix broke compose screen

  imp/js/compose-dimp.js |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/0d1f5587f8ff1d2ab31bf3191c38fa1f60a214cf
08/29/2012 12:40:57 PM Git Commit Comment #12 Reply to this comment
Changes have been made in Git (master):

commit 9abe9c04a9fad8addd5791e018769e5735dcf50e
Author: Jan Schneider <jan@horde.org>
Date:   Mon Jul 9 22:27:26 2012 +0200

     Fix JS errors (Bug #11251).

  imp/docs/CHANGES                       |    1 +
  imp/js/compose-dimp.js                 |    2 +-
  imp/package.xml                        |    2 ++
  imp/templates/dynamic/message.html.php |    4 ++++
  4 files changed, 8 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/9abe9c04a9fad8addd5791e018769e5735dcf50e
07/10/2012 07:26:28 AM leena (dot) heino (at) uta (dot) fi Comment #11 Reply to this comment
Thank you. The compose and popup windows now work and I'm able to 
compose messages and view messages in popup window.
07/10/2012 07:23:20 AM Michael Slusarz Assigned to Jan Schneider
Assigned to Michael Slusarz
State ⇒ Resolved
 
07/10/2012 07:09:16 AM Git Commit Comment #10 Reply to this comment
Changes have been made in Git (develop):

commit d218becb3ae3d69daeaedcef25a229d052ec51b4
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Tue Jul 10 00:19:25 2012 -0600

     Another fix for Bug #11251

  imp/js/compose-dimp.js             |    2 +-
  imp/lib/Dynamic/Compose/Common.php |    6 +++---
  2 files changed, 4 insertions(+), 4 deletions(-)

http://git.horde.org/horde-git/-/commit/d218becb3ae3d69daeaedcef25a229d052ec51b4
07/10/2012 06:07:04 AM leena (dot) heino (at) uta (dot) fi Comment #9 Reply to this comment
There is still this problem with javascript which prevents compose 
screen from working properly:
Error 2: Uncaught TypeError: Object #<Object> has no method 'size'
File: compose-dimp.js
Line: 1127
Code: if (DimpCore.context.ctx_msg_other.size()) {

Simple fix is to remove the size() method call as that method does not exist:
--- compose-dimp.js.orig        2012-07-10 08:54:14.979028558 +0300
+++ compose-dimp.js     2012-07-10 08:57:36.439150927 +0300
@@ -1124,7 +1124,7 @@
              callback: this.uniqueSubmitCallback.bind(this)
          });

-        if (DimpCore.context.ctx_msg_other.size()) {
+        if (DimpCore.context.ctx_msg_other) {
              DimpCore.addPopdown($('msg_other_options').down('A'), 
'msg_other', {
                  trigger: true
              });

07/10/2012 05:35:16 AM Git Commit Comment #8 Reply to this comment
Changes have been made in Git (develop):

commit 0d1f5587f8ff1d2ab31bf3191c38fa1f60a214cf
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Jul 9 23:08:41 2012 -0600

     Correctly fix Bug #11251: previous fix broke compose screen

  imp/js/compose-dimp.js |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/0d1f5587f8ff1d2ab31bf3191c38fa1f60a214cf
07/09/2012 08:28:56 PM Git Commit Comment #7 Reply to this comment
Changes have been made in Git (develop):

commit 9abe9c04a9fad8addd5791e018769e5735dcf50e
Author: Jan Schneider <jan@horde.org>
Date:   Mon Jul 9 22:27:26 2012 +0200

     Fix JS errors (Bug #11251).

  imp/docs/CHANGES                       |    1 +
  imp/js/compose-dimp.js                 |    2 +-
  imp/package.xml                        |    2 ++
  imp/templates/dynamic/message.html.php |    4 ++++
  4 files changed, 8 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/9abe9c04a9fad8addd5791e018769e5735dcf50e
07/09/2012 08:28:24 PM Jan Schneider Comment #6 Reply to this comment

[Show Quoted Text - 9 lines]
To what is it set?
07/09/2012 08:15:25 PM leena (dot) heino (at) uta (dot) fi Comment #5 Reply to this comment
Error 1: Uncaught TypeError: Cannot call method 'hide' of null
File: message-dimp.js
Line: 327
Code: $('dimpLoading').hide();
This had been fixed before the release. If you don't have the 
dimpLoading DIV in your compose window, your setup is broken.
Yes, the compose window does have that DIV ( /imp/dynamic.php?page=compose )

The problem is when trying to open a single message in a new window 
then that new window  ( /imp/dynamic.php?page=message ) does not have 
DIV section named "dimpLoading".
Error 2: Uncaught TypeError: Object #<Object> has no method 'size'
File: compose-dimp.js
Line: 1127
Code: if (DimpCore.context.ctx_msg_other.size()) {
DimpCore.context.ctx_msg_other is *always* set in the compose window.
You are right, DimpCore.context.ctx_msg_other is always set. But the 
error is that it does not seem to have method size().

Errors 1 and 2 cause message popup window to be shown as blank.
Error 2 makes compose window show just text "Loading...".
07/09/2012 07:15:06 PM Jan Schneider Comment #4 Reply to this comment

[Show Quoted Text - 11 lines]
This had been fixed before the release. If you don't have the 
dimpLoading DIV in your compose window, your setup is broken.
Error 2: Uncaught TypeError: Object #<Object> has no method 'size'
File: compose-dimp.js
Line: 1127
Code: if (DimpCore.context.ctx_msg_other.size()) {
DimpCore.context.ctx_msg_other is *always* set in the compose window.
07/09/2012 06:59:22 PM leena (dot) heino (at) uta (dot) fi Comment #3 Reply to this comment
These errors might be related to javascript errors reported on: 
#11248 #11249
Why? Do you get those error messages when loading the compose window?
This situation with blank pages are cause by two errors in javascript code.

Error 1: Uncaught TypeError: Cannot call method 'hide' of null
File: message-dimp.js
Line: 327
Code: $('dimpLoading').hide();

Error 2: Uncaught TypeError: Object #<Object> has no method 'size'
File: compose-dimp.js
Line: 1127
Code: if (DimpCore.context.ctx_msg_other.size()) {
07/09/2012 03:17:54 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
These errors might be related to javascript errors reported on: #11248 #11249
Why? Do you get those error messages when loading the compose window?
07/09/2012 03:08:52 PM leena (dot) heino (at) uta (dot) fi Comment #1
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Summary ⇒ Blank pages when using popup windows
Type ⇒ Bug
Queue ⇒ IMP
Reply to this comment
Compose window only shows text: "Loading..."

If message is opened in a new window it is shown as blank.

In both cases the text of the window can be read using View Source. So 
the page seems to load ok, but still nothing is shown.

These errors might be related to javascript errors reported on: #11248 #11249

Tested system: RHEL 6.2 (php 5.3.3 + RHEL patches)
Tested browsers: IE 9, Firefox 13.0.1, Opera 12, Chrome 20

Saved Queries