Tickets :: [#11234] Identity selection doesn't work

6.0.0-beta1

7/9/25

Summary	Identity selection doesn't work
Queue	IMP
Queue Version	Git develop
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	07/02/2012 (4755 days ago)
Due
Updated	08/29/2012 (4697 days ago)
Assigned	07/05/2012 (4752 days ago)
Resolved	07/05/2012 (4752 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

08/29/2012 12:40:28 PM	Git Commit	Comment #13	Reply to this comment
Changes have been made in Git (master): commit 193ef607b07f4e2e64b5b18f569700c861b6ef98 Author: Michael M Slusarz <slusarz@horde.org> Date: Thu Jul 5 16:23:00 2012 -0600 ~~Bug #11234~~: Fix identity selection when replying/forwarding to a message sent from a personal from address. imp/lib/Prefs/Identity.php \| 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/193ef607b07f4e2e64b5b18f569700c861b6ef98

07/05/2012 10:35:09 PM	Jan Schneider	Comment #12	Reply to this comment
[Show Quoted Text - 9 lines][Hide Quoted Text] I have no idea how this is working on your system. This was working for me because I was matching "tie-to" addresses. As you discovered, the search/match was failing at the "from" search, which is an extremely rare fringe case. This match would only be triggered if replying to one of your own messages Since replies to list are triggered at the tie-to level (lists will never be a From address), this was the reason I wasn't seeing this. Not quite, this happened in almost all cases, because if my identities would match the From: address, it wouldn't matter if only that address was compared. But since the To: address was dropped, in never worked, unless I had tied-to addresses set (didn't test the latter). Anyway, works fine now, thanks!

07/05/2012 10:27:29 PM	Michael Slusarz	Comment #11 State ⇒ Resolved	Reply to this comment
I have no idea how this is working on your system. This was working for me because I was matching "tie-to" addresses. As you discovered, the search/match was failing at the "from" search, which is an extremely rare fringe case. This match would only be triggered if replying to one of your own messages Since replies to list are triggered at the tie-to level (lists will never be a From address), this was the reason I wasn't seeing this.

07/05/2012 10:23:31 PM	Git Commit	Comment #10	Reply to this comment
Changes have been made in Git (develop): commit 193ef607b07f4e2e64b5b18f569700c861b6ef98 Author: Michael M Slusarz <slusarz@horde.org> Date: Thu Jul 5 16:23:00 2012 -0600 ~~Bug #11234~~: Fix identity selection when replying/forwarding to a message sent from a personal from address. imp/lib/Prefs/Identity.php \| 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/193ef607b07f4e2e64b5b18f569700c861b6ef98

07/05/2012 10:08:00 PM	Jan Schneider	Comment #9	Reply to this comment
Where is this happening, so I can easier track it down? The parsing of the URL parameter? IMP_Dynamic_Compose, around line 60. No, the identity selection if not using the parameter. The 'identity' key in the return array of IMP_Compose#replyMessage() and IMP_Compose#forwardMessage(). This is what happens: in Imp_Prefs_Identity#getMatchingIdentity() all message addresses (From:, To:) are passed to contains(). Horde_Mail_Rfc822_List#contains() wraps this list into Horde_Mail_Rfc822_Address() which only contains the first address (From:) after that. Of course the match() below doesn't work anymore then. I have no idea how this is working on your system.

07/05/2012 09:43:20 PM	Michael Slusarz	Comment #8	Reply to this comment
Where is this happening, so I can easier track it down? The parsing of the URL parameter? IMP_Dynamic_Compose, around line 60. No, the identity selection if not using the parameter. The 'identity' key in the return array of IMP_Compose#replyMessage() and IMP_Compose#forwardMessage().

07/05/2012 09:24:56 PM	Jan Schneider	Comment #7	Reply to this comment
Where is this happening, so I can easier track it down? The parsing of the URL parameter? IMP_Dynamic_Compose, around line 60. No, the identity selection if not using the parameter.

07/05/2012 09:15:14 PM	Michael Slusarz	Comment #6	Reply to this comment
Where is this happening, so I can easier track it down? The parsing of the URL parameter? IMP_Dynamic_Compose, around line 60.

07/05/2012 08:26:16 PM	Jan Schneider	Comment #5	Reply to this comment
Should the identity parameter still be passed to the compose window? I don't see it in its URL. Or this completely matched in compose-dimp.php now? The identity parameter CAN be passed - but it will be overridden by the identity determination when determining reply/forward data (in other words: preferences trump any identity parameter passed in URL/form data). Where is this happening, so I can easier track it down?

07/05/2012 08:04:30 PM	Michael Slusarz	Comment #4	Reply to this comment
Should the identity parameter still be passed to the compose window? I don't see it in its URL. Or this completely matched in compose-dimp.php now? The identity parameter CAN be passed - but it will be overridden by the identity determination when determining reply/forward data (in other words: preferences trump any identity parameter passed in URL/form data).

07/05/2012 07:30:11 PM	Jan Schneider	Comment #3	Reply to this comment
Should the identity parameter still be passed to the compose window? I don't see it in its URL. Or this completely matched in compose-dimp.php now?

07/05/2012 07:07:03 PM	Michael Slusarz	Comment #2 State ⇒ Feedback	Reply to this comment
Works fine here. Just replied to a list message, and my identity was correctly set to my (non-default) Horde identity.

07/02/2012 05:25:21 PM	Jan Schneider	Comment #1 State ⇒ Assigned Patch ⇒ No Milestone ⇒ Assigned to Michael Slusarz Queue ⇒ IMP Summary ⇒ Identity selection doesn't work Type ⇒ Bug Priority ⇒ 1. Low	Reply to this comment
Automatic identity selection on replies/forwards doesn't work anymore.