6.0.0-alpha14
7/2/25

[#11208] recursive delete of folder - change (fatal) error message
Summary recursive delete of folder - change (fatal) error message
Queue Gollem
Queue Version 2.0.2
Type Enhancement
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester lauffer (at) ph-freiburg (dot) de
Created 06/01/2012 (4779 days ago)
Due
Updated 11/26/2012 (4601 days ago)
Assigned
Resolved 11/26/2012 (4601 days ago)
Milestone
Patch No

History
11/26/2012 10:34:11 AM Jan Schneider Assigned to Jan Schneider
Taken from Horde DevelopersHorde Developers
State ⇒ Resolved
 
11/26/2012 10:33:57 AM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (master):

commit 63f19ac6dd4db646bf2433fedf557a597cca6acd
Author: Jan Schneider <jan@horde.org>
Date:   Mon Nov 26 11:33:24 2012 +0100

     Consistently throw Gollem_Exceptions from Gollem:: class (Bug #11208).

  gollem/lib/Gollem.php |  134 
++++++++++++++++++++++++++++++++-----------------
  gollem/manager.php    |   14 +++---
  2 files changed, 94 insertions(+), 54 deletions(-)

http://git.horde.org/horde-git/-/commit/63f19ac6dd4db646bf2433fedf557a597cca6acd
10/12/2012 01:40:37 PM Michael Rubinsky Comment #4
Assigned to Horde DevelopersHorde Developers
State ⇒ Accepted
Reply to this comment
Makes sense to me. The Gollem:: class currently leaks 
Horde_Vfs_Exceptions that are not caught in the controller scripts. 
Don't know if this was intentional or not, but we need to either 
always throw Gollem_Exceptions, or catch the Vfs_Exception in the 
calling code.
06/04/2012 12:19:50 PM lauffer (at) ph-freiburg (dot) de Comment #3
New Attachment: recursive_delete-Horde_Fatal_Error.html Download
Reply to this comment
And what *is* the (full) fatal error?
?

"Unable to delete "/Folder", the directory is not empty" - everybody 
knows I thought... see attached recursive_delete-Horde_Fatal_Error.html
06/04/2012 12:12:39 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
And what *is* the (full) fatal error?
06/01/2012 01:47:20 PM lauffer (at) ph-freiburg (dot) de Comment #1
Priority ⇒ 1. Low
State ⇒ New
Patch ⇒ No
Milestone ⇒
Queue ⇒ Gollem
Summary ⇒ recursive delete of folder - change (fatal) error message
Type ⇒ Enhancement
Reply to this comment
If you will try to delete a not empty folder and you did not change 
your settings to allow recursive delets you get a fatal error page.

I would say this error report/page is "wrong" since it is not a 
software bug or any other serious problem.

I would prefere to just send a note to the user that the folder is not 
empty and so it will not be deleted. Maybe add a note about changing 
this behavior in the user settings....

Regards, Stephan

Saved Queries