6.0.0-beta1
7/6/25

[#11197] Filtering fails with some fields
Summary Filtering fails with some fields
Queue Ingo
Queue Version 2.0.7
Type Bug
State Resolved
Priority 3. High
Owners slusarz (at) horde (dot) org
Requester gabriel.guntin (at) unq (dot) edu (dot) ar
Created 05/15/2012 (4800 days ago)
Due
Updated 06/26/2012 (4758 days ago)
Assigned 06/06/2012 (4778 days ago)
Resolved 06/21/2012 (4763 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
06/26/2012 02:16:31 PM Git Commit Comment #28 Reply to this comment
Changes have been made in Git (develop):

commit 958d00d4fdbe5221594c6c574ff9a1988d223bbf
Author: Jan Schneider <jan@horde.org>
Date:   Tue Jun 26 11:59:54 2012 +0200

     [mms] Fix patch for filtering on combination fields (Bug #11197).

  ingo/docs/CHANGES |    1 +
  ingo/package.xml  |    2 ++
  2 files changed, 3 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/958d00d4fdbe5221594c6c574ff9a1988d223bbf
06/26/2012 10:04:32 AM Git Commit Comment #27 Reply to this comment
Changes have been made in Git (master):

commit 958d00d4fdbe5221594c6c574ff9a1988d223bbf
Author: Jan Schneider <jan@horde.org>
Date:   Tue Jun 26 11:59:54 2012 +0200

     [mms] Fix patch for filtering on combination fields (Bug #11197).

  ingo/docs/CHANGES |    1 +
  ingo/package.xml  |    2 ++
  2 files changed, 3 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/958d00d4fdbe5221594c6c574ff9a1988d223bbf
06/21/2012 10:16:56 PM Michael Slusarz State ⇒ Resolved
 
06/18/2012 06:36:09 AM cne (at) ruhrverband (dot) de Comment #26 Reply to this comment
It is fixed. Sorry for delay.

06/16/2012 05:44:53 PM Jan Schneider Comment #25
Summary ⇒ Filtering fails with some fields
Reply to this comment
Can somebody *please* test those (both!) patches and report back if 
this is fixed. We won't release a new version without confirmation.
06/08/2012 11:15:18 PM Michael Slusarz Comment #24 Reply to this comment
Not solved!
You didn't apply BOTH patches.
06/08/2012 01:16:11 PM cne (at) ruhrverband (dot) de Comment #23 Reply to this comment
2012-06-08T15:12:38+02:00 DEBUG: HORDE [ingo] SQL  (0,0025s)
        SELECT * FROM ingo_rules WHERE rule_owner = 'rvuser' ORDER BY 
rule_order [pid 3666 on line 803 of 
"/usr/share/php/Horde/Db/Adapter/Base.php"]
2012-06-08T15:12:38+02:00 WARN: HORDE [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 3666 on line 626 of 
"/usr/share/php/Horde/Imap/Client/Search/Query.php"]
  7. Ingo_Script_Imap->perform() /var/www/horde/ingo/lib/Api.php:108
  8. Horde_Imap_Client_Search_Query->andSearch() 
/var/www/horde/ingo/lib/Script/Imap.php:236
2012-06-08T15:12:38+02:00 DEBUG: HORDE [ingo]  1. 
IMP_Mailbox->filter() /var/www/horde/imp/mailbox.php:214
  7. Ingo_Script_Imap->perform() /var/www/horde/ingo/lib/Api.php:108
  8. Horde_Imap_Client_Search_Query->andSearch() 
/var/www/horde/ingo/lib/Script/Imap.php:236
2012-06-08T15:12:39+02:00 DEBUG: HORDE [ingo] Filteraktivität: Die 
Nachricht "rhsh rfesrh" von "<123@456.78>" wurde zum Ordner "test" 
verschoben. [pid 3666 on line 27 of 
"/usr/share/php/Horde/Core/Notification/Handler/Decorator/Hordelog.php"]
2012-06-08T15:12:39+02:00 DEBUG: HORDE [ingo] Filteraktivität: Die 
Nachricht "123" von "<123@456.78>" wurde zum Ordner "test" verschoben. 
[pid 3666 on line 27 of 
"/usr/share/php/Horde/Core/Notification/Handler/Decorator/Hordelog.php"]
2012-06-08T15:12:39+02:00 DEBUG: HORDE [ingo] Filteraktivität: Die 
Nachricht "test" von "<123@456.78>" wurde zum Ordner "test" 
verschoben. [pid 3666 on line 27 of 
"/usr/share/php/Horde/Core/Notification/Handler/Decorator/Hordelog.php"]

Not solved!
06/06/2012 02:22:37 PM gedeoncamdg (at) yahoo (dot) ca Comment #22 Reply to this comment
If this is such high priority, did anybody actually test the 
committed fixes and can confirm whether the issue is fixed now or not?
I would like to test but I don't know how to get/apply patches. Also 
the installation is pear installation. If anybody can provide me help 
on how to do so, I am willing to test and give feedback on whether the 
problem disappeared.
06/06/2012 09:34:25 AM Jan Schneider Comment #21
State ⇒ Feedback
Reply to this comment
If this is such high priority, did anybody actually test the committed 
fixes and can confirm whether the issue is fixed now or not?
06/05/2012 07:49:48 PM Git Commit Comment #20 Reply to this comment
Changes have been made in Git (develop):

commit 460d3766089df6b20f0ec47d51ea27a0ef654fc7
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Jun 4 14:23:26 2012 -0600

     Bug #11197: Another BC fix

  ingo/lib/Script/Imap.php |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/460d3766089df6b20f0ec47d51ea27a0ef654fc7
06/04/2012 08:23:44 PM Git Commit Comment #19 Reply to this comment
Changes have been made in Git (master):

commit 460d3766089df6b20f0ec47d51ea27a0ef654fc7
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Jun 4 14:23:26 2012 -0600

     Bug #11197: Another BC fix

  ingo/lib/Script/Imap.php |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/460d3766089df6b20f0ec47d51ea27a0ef654fc7
06/04/2012 05:11:04 PM matinelli (at) matinelli (dot) com Comment #18 Reply to this comment
I guess line 159 of ingo/lib/Script/Imap.php need a fix as well from:
$query->andSearch($or_ob);
to
$query->andSearch(array($or_ob));

[Show Quoted Text - 22 lines]
06/04/2012 04:53:32 PM matinelli (at) matinelli (dot) com Comment #17 Reply to this comment
Hi,
I had the same issue and I have applied the fix on 
ingo/lib/Script/Imap.php however I am now getting the following:

HORDE: [ingo] PHP ERROR: array_merge(): Argument #2 is not an array 
[pid xxx on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]

[Show Quoted Text - 12 lines]
06/04/2012 03:14:48 PM Git Commit Comment #16 Reply to this comment
Changes have been made in Git (develop):

commit 958daacad7e1b85c539a9f5fc00b9fade123c645
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu May 31 12:00:42 2012 -0600

     Make this call BC (Bug #11197)

  ingo/lib/Script/Imap.php |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/958daacad7e1b85c539a9f5fc00b9fade123c645
06/01/2012 04:46:25 PM Michael Slusarz Comment #15 Reply to this comment
No matter if headder is matched or not, ALL messages are moved to 
the directory dir1
This is exactly what would be expected given the error message 
reported.  Since the specific AND/OR rules are not correctly added to 
the base query object, the base query object would default to an ALL 
search.
06/01/2012 01:58:01 PM gedeoncamdg (at) yahoo (dot) ca Comment #14 Reply to this comment
Forgot to describe how il is broken:

Filtering rules are as follows:
if match X-headder1 then move to directory dir1 stop
if match X-headder2 then move to directory dir2 stop
...

No matter if headder is matched or not, ALL messages are moved to the 
directory dir1

Also, ingo version is 2.0.8

Hope this helps
05/31/2012 07:11:25 PM gedeoncamdg (at) yahoo (dot) ca Comment #13 Reply to this comment
Hello,

I just upgraded to the latest groupware edition et filtering is now 
broken and I believe il has to do with this bug. My installation was 
up to date last friday, up and running smoothly and filtering have 
been running fine for months.

My filter backend is SQL.
The filter rules look for specific custom headder and move message to 
different folders accordingly. All the rules are simple, i.e. only one 
headder is checked, if matched, move message then stop.

Here is what I get in the syslog when filter is applied. Hope it will help

May 31 14:57:39 scommuns HORDE: [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 30898 on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]
May 31 14:57:39 scommuns HORDE: [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 30898 on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]
May 31 14:57:39 scommuns HORDE: [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 30898 on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]
May 31 14:57:40 scommuns HORDE: [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 30898 on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]
May 31 14:57:40 scommuns HORDE: [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 30898 on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]
May 31 14:57:40 scommuns HORDE: [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 30898 on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]
May 31 14:57:40 scommuns HORDE: [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 30898 on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]
May 31 14:57:40 scommuns HORDE: [ingo] PHP ERROR: array_merge(): 
Argument #2 is not an array [pid 30898 on line 626 of 
"/usr/share/pear/Horde/Imap/Client/Search/Query.php"]

05/31/2012 06:02:09 PM Michael Slusarz Comment #12 Reply to this comment
Or maybe this helps, since this code works with Imap_Client v2 but not v1.
05/31/2012 06:00:53 PM Git Commit Comment #11 Reply to this comment
Changes have been made in Git (master):

commit 958daacad7e1b85c539a9f5fc00b9fade123c645
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu May 31 12:00:42 2012 -0600

     Make this call BC (Bug #11197)

  ingo/lib/Script/Imap.php |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/958daacad7e1b85c539a9f5fc00b9fade123c645
05/31/2012 05:38:26 PM Michael Slusarz Comment #10 Reply to this comment
I'm going to revert then.  I don't have time to look at this right now.
05/31/2012 10:27:55 AM Jan Schneider Comment #9
State ⇒ Assigned
Priority ⇒ 3. High
Reply to this comment
This seems to have done more bad than good.
05/29/2012 05:43:13 PM Git Commit Comment #8 Reply to this comment
Changes have been made in Git (develop):

commit 3a1776beec29f6b5cd8aaa213f2c93b04d4d7682
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu May 24 12:26:17 2012 -0600

     [mms] Fix IMAP filtering on combination fields (Bug #11197).

  ingo/docs/CHANGES        |    1 +
  ingo/lib/Script/Imap.php |   48 
+++++++++++++++++++++++-----------------------
  ingo/package.xml         |    2 +
  3 files changed, 27 insertions(+), 24 deletions(-)

http://git.horde.org/horde-git/-/commit/3a1776beec29f6b5cd8aaa213f2c93b04d4d7682
05/24/2012 06:29:51 PM Michael Slusarz Comment #7
State ⇒ Feedback
Reply to this comment
Does this fix?
05/24/2012 06:26:45 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (master):

commit 3a1776beec29f6b5cd8aaa213f2c93b04d4d7682
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu May 24 12:26:17 2012 -0600

     [mms] Fix IMAP filtering on combination fields (Bug #11197).

  ingo/docs/CHANGES        |    1 +
  ingo/lib/Script/Imap.php |   48 
+++++++++++++++++++++++-----------------------
  ingo/package.xml         |    2 +
  3 files changed, 27 insertions(+), 24 deletions(-)

http://git.horde.org/horde-git/-/commit/3a1776beec29f6b5cd8aaa213f2c93b04d4d7682
05/16/2012 02:55:51 PM Jan Schneider State ⇒ Assigned
Assigned to Michael Slusarz
 
05/16/2012 02:30:25 PM gabriel (dot) guntin (at) unq (dot) edu (dot) ar Comment #5
New Attachment: imp-debug-log Download
Reply to this comment
See attached file imp-debug-log,  it was generated while processing 
the filter for 4 items on inbox, that were moved by the filter to 
"Nueva" folder.
05/15/2012 06:30:07 PM Jan Schneider Comment #4 Reply to this comment
To further debug this issue, we need details of the IMP -> IMAP/POP 
communication.

To enable debugging, see instructions contained in 
imp/config/backends.php (the 'debug' config parameter).

Debugging should not be enabled on a production server,   Attach/post 
only the portion of the log that directly deals with the problem 
reported (it may be simplest to clear the log file and then perform 
the event that causes the error).
05/15/2012 05:54:15 PM gabriel (dot) guntin (at) unq (dot) edu (dot) ar Comment #3 Reply to this comment
You need to provide much more information, most importantly, what 
filter backend you use, and how the generated script looks like, if 
any.
We are using default settings provided in ingo/config/backends.php, so 
imap is the only backend enabled.
In the other hand in config/conf.php we have setted 
$conf[storage][driver]=SQL, as you can see all settings are by default.
05/15/2012 05:35:32 PM Jan Schneider Comment #2
Priority ⇒ 1. Low
State ⇒ Feedback
Reply to this comment
You need to provide much more information, most importantly, what 
filter backend you use, and how the generated script looks like, if any.
05/15/2012 05:21:10 PM gabriel (dot) guntin (at) unq (dot) edu (dot) ar Comment #1
Priority ⇒ 3. High
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Summary ⇒ Filternig fails with some fields
Type ⇒ Bug
Queue ⇒ Ingo
Reply to this comment
Using the following fields in the definition of a filter the result of 
the evaluation is always "true", and therefore the filter action 
affects all messages in inbox:  Destination (To,Cc,Bcc,etc.)  -   
Source (From,Reply-to,etc.)  -  Participant (From,To,etc.)

Saved Queries