Tickets :: [#11157] JQM CSS files added with incorrect priority

6.0.0-beta1

7/5/25

Summary	JQM CSS files added with incorrect priority
Queue	Horde Framework Packages
Queue Version	Git develop
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	04/20/2012 (4824 days ago)
Due
Updated	08/29/2012 (4693 days ago)
Assigned
Resolved	04/24/2012 (4820 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

08/29/2012 12:36:53 PM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git (master): commit ad66c314ebdc239d6bd9b18b62e43d7d6156fe9a Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Apr 23 22:12:23 2012 -0600 ~~Bug #11157~~: External stylesheets should always be loaded first, before Horde theme stylesheets framework/Core/lib/Horde/Themes/Css.php \| 25 ++++++++++++++----------- 1 files changed, 14 insertions(+), 11 deletions(-) http://git.horde.org/horde-git/-/commit/ad66c314ebdc239d6bd9b18b62e43d7d6156fe9a

04/24/2012 10:31:34 PM	Michael Slusarz	Comment #6	Reply to this comment
Think the solution is not JQM specific: ALL external stylesheets should be loaded first, to allow Horde themes to override any entry. That was my first idea too, but isn't that also used to load page-specific styles? Or don't we have any such things? Ansel, is supposed to at least, allow for gallery-style specific CSS files. AFAICT, this fix is still correct. If you really don't want Horde to overwrite page-specific styles, don't include the theme CSS on that page. Otherwise, Theme CSS should always trump external CSS (and hook data should always be allowed to overwrite any CSS value).

04/24/2012 01:39:53 PM	Michael Rubinsky	Comment #5	Reply to this comment
Think the solution is not JQM specific: ALL external stylesheets should be loaded first, to allow Horde themes to override any entry. That was my first idea too, but isn't that also used to load page-specific styles? Or don't we have any such things? Ansel, is supposed to at least, allow for gallery-style specific CSS files.

04/24/2012 08:45:57 AM	Jan Schneider	Comment #4	Reply to this comment
Think the solution is not JQM specific: ALL external stylesheets should be loaded first, to allow Horde themes to override any entry. That was my first idea too, but isn't that also used to load page-specific styles? Or don't we have any such things?

04/24/2012 04:26:01 AM	Michael Slusarz	Comment #3 State ⇒ Resolved	Reply to this comment
Think the solution is not JQM specific: ALL external stylesheets should be loaded first, to allow Horde themes to override any entry.

04/24/2012 04:25:08 AM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (develop): commit ad66c314ebdc239d6bd9b18b62e43d7d6156fe9a Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Apr 23 22:12:23 2012 -0600 ~~Bug #11157~~: External stylesheets should always be loaded first, before Horde theme stylesheets framework/Core/lib/Horde/Themes/Css.php \| 25 ++++++++++++++----------- 1 files changed, 14 insertions(+), 11 deletions(-) http://git.horde.org/horde-git/-/commit/ad66c314ebdc239d6bd9b18b62e43d7d6156fe9a

04/20/2012 05:12:28 PM	Jan Schneider	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ JQM CSS files added with incorrect priority Queue ⇒ Horde Framework Packages Assigned to Michael Slusarz Milestone ⇒ Patch ⇒ No State ⇒ Assigned	Reply to this comment
The JQM CSS files are added as regular CSS files by Horde_PageOutput. As a result, they are loaded after the base CSS files (actually only the smartmobile/ files because of 'subonly'). In this case the order has to be reverse though, because the JQM files define the base rendering and the Horde CSS files should overwrite them, i.e. loaded after the JQM files.