Tickets :: [#11157] JQM CSS files added with incorrect priority

6.0.0-RC7

6/18/26

History
Attachments
Comment
Watch
Download

Summary	JQM CSS files added with incorrect priority
Queue	Horde Framework Packages
Queue Version	Git develop
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	4/20/12 (5172 days ago)
Due
Updated	8/29/12 (5041 days ago)
Assigned
Resolved	4/24/12 (5168 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

5312	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git (master): commit ad66c314ebdc239d6bd9b18b62e43d7d6156fe9a Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Apr 23 22:12:23 2012 -0600 ~~Bug #11157~~: External stylesheets should always be loaded first, before Horde theme stylesheets framework/Core/lib/Horde/Themes/Css.php \| 25 ++++++++++++++----------- 1 files changed, 14 insertions(+), 11 deletions(-) http://git.horde.org/horde-git/-/commit/ad66c314ebdc239d6bd9b18b62e43d7d6156fe9a

3410	Michael Slusarz	Comment #6	Reply to this comment
Think the solution is not JQM specific: ALL external stylesheets should be loaded first, to allow Horde themes to override any entry. That was my first idea too, but isn't that also used to load page-specific styles? Or don't we have any such things? Ansel, is supposed to at least, allow for gallery-style specific CSS files. AFAICT, this fix is still correct. If you really don't want Horde to overwrite page-specific styles, don't include the theme CSS on that page. Otherwise, Theme CSS should always trump external CSS (and hook data should always be allowed to overwrite any CSS value).

531	Michael Rubinsky	Comment #5	Reply to this comment
Think the solution is not JQM specific: ALL external stylesheets should be loaded first, to allow Horde themes to override any entry. That was my first idea too, but isn't that also used to load page-specific styles? Or don't we have any such things? Ansel, is supposed to at least, allow for gallery-style specific CSS files.

578	Jan Schneider	Comment #4	Reply to this comment
Think the solution is not JQM specific: ALL external stylesheets should be loaded first, to allow Horde themes to override any entry. That was my first idea too, but isn't that also used to load page-specific styles? Or don't we have any such things?

14	Michael Slusarz	Comment #3 State ⇒ Resolved	Reply to this comment
Think the solution is not JQM specific: ALL external stylesheets should be loaded first, to allow Horde themes to override any entry.

84	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (develop): commit ad66c314ebdc239d6bd9b18b62e43d7d6156fe9a Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Apr 23 22:12:23 2012 -0600 ~~Bug #11157~~: External stylesheets should always be loaded first, before Horde theme stylesheets framework/Core/lib/Horde/Themes/Css.php \| 25 ++++++++++++++----------- 1 files changed, 14 insertions(+), 11 deletions(-) http://git.horde.org/horde-git/-/commit/ad66c314ebdc239d6bd9b18b62e43d7d6156fe9a

285	Jan Schneider	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ JQM CSS files added with incorrect priority Queue ⇒ Horde Framework Packages Assigned to Michael Slusarz Milestone ⇒ Patch ⇒ No State ⇒ Assigned	Reply to this comment
The JQM CSS files are added as regular CSS files by Horde_PageOutput. As a result, they are loaded after the base CSS files (actually only the smartmobile/ files because of 'subonly'). In this case the order has to be reverse though, because the JQM files define the base rendering and the Horde CSS files should overwrite them, i.e. loaded after the JQM files.