Summary | the "Purge Deleted" action in Dynamic view does not refresh the message list |
Queue | IMP |
Queue Version | 5.0.20 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | slusarz (at) horde (dot) org |
Requester | jcblanco (at) fi (dot) upm (dot) es |
Created | 04/11/2012 (4840 days ago) |
Due | |
Updated | 07/04/2012 (4756 days ago) |
Assigned | 04/12/2012 (4839 days ago) |
Resolved | 04/12/2012 (4839 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
the "purge deleted" option of DIMP works and with 1.5.5 does not. The
messages are deleted but the message view is not refreshed correclty,
if the last message is deleted none of the purged messages disappear
form the view and if not the view is updated but in a wrong way.
modification may be:
if (!empty($res['lookup']) || count($ob['uids'])) {
$ob['lookup'] = array_merge($ob['lookup'], $res['lookup']);
}
'uids' when the conditional code only refers to the 'lookup' index.
patch from you when committed, however today I've installed the last
releases of Horde/IMP including the new version of Horde_Imap_Client
1.5.5. That version includes this last change of
bug 11143, wellwith it the described error is back again while with
Horde_Imap_Client 1.5.4 the error does not occur
between 1.5.4 and 1.5.5.
modification may be:
if (!empty($res['lookup']) || count($ob['uids'])) {
$ob['lookup'] = array_merge($ob['lookup'], $res['lookup']);
}
patch from you when committed, however today I've installed the last
releases of Horde/IMP including the new version of Horde_Imap_Client
1.5.5. That version includes this last change of
bug 11143, well withit the described error is back again while with Horde_Imap_Client
1.5.4 the error does not occur
commit f458c3b2482e0b1d8ce6a96d9fa5e24622401961
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Apr 13 10:30:43 2012 -0600
Better fix for
Bug #11143.../Imap_Client/lib/Horde/Imap/Client/Socket.php | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
http://git.horde.org/horde-git/-/commit/f458c3b2482e0b1d8ce6a96d9fa5e24622401961
commit 7f1c7ca00c593c64a35ba1ee5ac57b31d37e254f
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Apr 13 09:35:51 2012 -0600
We need both of these checks (
Bug #11143).../Imap_Client/lib/Horde/Imap/Client/Socket.php | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/7f1c7ca00c593c64a35ba1ee5ac57b31d37e254f
commit f458c3b2482e0b1d8ce6a96d9fa5e24622401961
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Apr 13 10:30:43 2012 -0600
Better fix for
Bug #11143.../Imap_Client/lib/Horde/Imap/Client/Socket.php | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
http://git.horde.org/horde-git/-/commit/f458c3b2482e0b1d8ce6a96d9fa5e24622401961
commit 7f1c7ca00c593c64a35ba1ee5ac57b31d37e254f
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Apr 13 09:35:51 2012 -0600
We need both of these checks (
Bug #11143).../Imap_Client/lib/Horde/Imap/Client/Socket.php | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/7f1c7ca00c593c64a35ba1ee5ac57b31d37e254f
fine again.
commit bf80190466648c4c8391d8852fb5e6302e6fbb00
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Apr 12 16:37:28 2012 -0600
[mms] Fix regression in caching code (
Bug #11143)..../Imap_Client/lib/Horde/Imap/Client/Socket.php | 2 +-
framework/Imap_Client/package.xml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/bf80190466648c4c8391d8852fb5e6302e6fbb00
commit 327c9a3b8cea4292c00c24d8af0a80d62234ce37
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Apr 12 16:36:57 2012 -0600
Revert "[mms] Fix regression in caching code (
Bug #11143)."This reverts commit 382e7efa8d20ed03f9b1d77b2cfc80a3ee5269f4.
framework/Core/package.xml | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/327c9a3b8cea4292c00c24d8af0a80d62234ce37
commit 382e7efa8d20ed03f9b1d77b2cfc80a3ee5269f4
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Apr 12 16:35:59 2012 -0600
[mms] Fix regression in caching code (
Bug #11143).framework/Core/package.xml | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/382e7efa8d20ed03f9b1d77b2cfc80a3ee5269f4
commit bf80190466648c4c8391d8852fb5e6302e6fbb00
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Apr 12 16:37:28 2012 -0600
[mms] Fix regression in caching code (
Bug #11143)..../Imap_Client/lib/Horde/Imap/Client/Socket.php | 2 +-
framework/Imap_Client/package.xml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/bf80190466648c4c8391d8852fb5e6302e6fbb00
commit 327c9a3b8cea4292c00c24d8af0a80d62234ce37
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Apr 12 16:36:57 2012 -0600
Revert "[mms] Fix regression in caching code (
Bug #11143)."This reverts commit 382e7efa8d20ed03f9b1d77b2cfc80a3ee5269f4.
framework/Core/package.xml | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/327c9a3b8cea4292c00c24d8af0a80d62234ce37
Priority ⇒ 2. Medium
State ⇒ Resolved
another bug. $ob['uids'] won't be empty because it is an object - we
need to explicitly do a count() on the object to get the number of UID
members.
This has been fixed in Horde_Imap_Client 1.5.4.
commit 382e7efa8d20ed03f9b1d77b2cfc80a3ee5269f4
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Apr 12 16:35:59 2012 -0600
[mms] Fix regression in caching code (
Bug #11143).framework/Core/package.xml | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/382e7efa8d20ed03f9b1d77b2cfc80a3ee5269f4
but I'm using the patched of the
#11137bug of Imap_Client (1.5.3)and the problem persist. I have been doing some tests and I think that
the problem is related to the change in _getSeqUidLookup function, If
I revert the change in line 3724 to "if (!count($ob['uids'])) {"
instead of "if (empty($ob['uids'])) {"
the message list seems to be updated correctly.
#11137.think that the problem is caused bye Horde_Imap_Client-1.5.2, If I
reinstall the 1.5.1 version the Purge seems to work fine again. Hope
this helps
State ⇒ Assigned
Assigned to Michael Slusarz
delete the last message in the folder; if the deleted messages dows
not include the last one the message list is updated but in wrong way,
all but the first deleted messages and the last undeleted message were
removed from the list, one of the deleted messages remains instead of
the last. Reloading the page show the correct message list.
Priority ⇒ 3. High
Type ⇒ Bug
Summary ⇒ the "Purge Deleted" action in Dynamic view does not refresh the message list
Due ⇒ 04/11/2012
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
IMP 5.0.20, I have a problem purging deleted messages using the
dynamic view. If I delete various messages in a folder and then go to
Other -> "Purge Deleted" de list of messages is not updated, however
if I open a different folder and came back to the first one, the
message list is updated. The messages are purged in the server.