6.0.0-beta1
7/20/25

[#11108] Changing sort order break searches
Summary Changing sort order break searches
Queue IMP
Queue Version 5.0.23
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester jan (at) horde (dot) org
Created 03/27/2012 (4863 days ago)
Due
Updated 08/24/2012 (4713 days ago)
Assigned 05/01/2012 (4828 days ago)
Resolved 08/24/2012 (4713 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
08/24/2012 01:45:42 AM Michael Slusarz Comment #10
Taken from Jan Schneider
State ⇒ Resolved
Version ⇒ 5.0.23
Reply to this comment
Fixed in 5.0.24.  Was not broken in IMP 6.
08/24/2012 01:44:23 AM Git Commit Comment #9 Reply to this comment
Changes have been made in Git (FRAMEWORK_4):

commit 13c0cb35374536140696adf3abb93e5155fa0392
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu Aug 23 19:44:06 2012 -0600

     [mms] Fix changing sort order in dynamic search mailboxes (Bug #11108).

  imp/docs/CHANGES   |    1 +
  imp/js/dimpbase.js |   28 +++++++++++++++++++---------
  imp/package.xml    |    2 ++
  3 files changed, 22 insertions(+), 9 deletions(-)

http://git.horde.org/horde-git/-/commit/13c0cb35374536140696adf3abb93e5155fa0392
06/16/2012 05:47:32 PM Jan Schneider Comment #8 Reply to this comment
Still can't reproduce.  And the code you reference (Viewport:fetch 
handler) specifically has code to not hide the searchbar if we are 
currently in a search mailbox:

             if (!this.isSearch()) {
                 this.showSearchbar(false);
             }
Cannot find this code in master.
05/24/2012 06:30:30 PM Michael Slusarz Comment #7
Assigned to Jan Schneider
Reply to this comment
Ping?
05/01/2012 04:45:05 AM Michael Slusarz Comment #6
State ⇒ Feedback
Reply to this comment
Still can't reproduce.  And the code you reference (Viewport:fetch 
handler) specifically has code to not hide the searchbar if we are 
currently in a search mailbox:

             if (!this.isSearch()) {
                 this.showSearchbar(false);
             }
04/27/2012 09:16:24 AM Jan Schneider State ⇒ Assigned
 
04/05/2012 01:09:32 PM Jan Schneider Comment #5 Reply to this comment
The search bar hiding happens in the ViewPort:fetch observer in 
dimpbase.php line 775. It's fired from viewport's _fetchBufferDo() 
line 623.
04/04/2012 11:19:45 PM Michael Slusarz Comment #4 Reply to this comment
Sorry, this should have read "search criterion".
This also works perfectly here.
03/28/2012 09:41:42 AM Jan Schneider Comment #3 Reply to this comment
Sorry, this should have read "search criterion".
03/28/2012 04:31:50 AM Michael Slusarz Comment #2
State ⇒ Feedback
Reply to this comment
Works perfectly here.  Tested with quicksearch in INBOX and with the 
Virtual Inbox.
03/27/2012 09:12:11 AM Jan Schneider Comment #1
Patch ⇒ No
State ⇒ Assigned
Milestone ⇒
Assigned to Michael Slusarz
Queue ⇒ IMP
Summary ⇒ Changing sort order break searches
Type ⇒ Bug
Priority ⇒ 1. Low
Reply to this comment
If changing the sort order while displaying search results, the new 
order is not used, but instead the "search bar" disappears.

Saved Queries