Summary | Smartmobile view improvements |
Queue | IMP |
Queue Version | Git master |
Type | Enhancement |
State | Resolved |
Priority | 2. Medium |
Owners | jan (at) horde (dot) org, slusarz (at) horde (dot) org |
Requester | slusarz (at) horde (dot) org |
Created | 03/24/2012 (4854 days ago) |
Due | |
Updated | 08/29/2012 (4696 days ago) |
Assigned | |
Resolved | 04/07/2012 (4840 days ago) |
Milestone | 6 |
Patch | No |
commit 634ee5c7da44d0a847db2113d084f3340fd9e5e3
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sat Apr 7 14:21:39 2012 -0600
Ticket #11103: Remove confirmation when deleting a messageimp/js/mobile.js | 29 ++++++++++++-----------------
imp/templates/mobile/message.html.php | 21 +++++++++++----------
imp/themes/default/mobile.css | 3 +++
3 files changed, 26 insertions(+), 27 deletions(-)
http://git.horde.org/horde-git/-/commit/634ee5c7da44d0a847db2113d084f3340fd9e5e3
commit b506993cea14ba0713c1cd769a1822259823a920
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sat Apr 7 13:53:00 2012 -0600
Bug #11103: Re-add delay to showing notifications on page loadThis event is being fired too quickly, so the history is not being
updated before switching to the notification view. This was completely
breaking the ability to use the smartmobile view on actual smartmobile
devices (e.g. Galaxy Nexus), since closing the notification window was
returning to the previous page in the history - the login page - instead
of the previous view in the current page.
This is a total hack, but I couldn't figure out any other way of doing
this in either jquery or jquery mobile. Not sure if this has been fixed
for 1.1.
.../Notification/Listener/SmartmobileStatus.php | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/b506993cea14ba0713c1cd769a1822259823a920
commit 86cee2742665afd3b6d9e41e93521b15e204815e
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Mar 28 19:05:54 2012 -0600
Bug #11103: Fix reloading views in smartmobile viewNot sure why this is needed. onchangepage should only be triggered if
the hash changes anyway. And this was preventing viewport cache
updates.
imp/js/mobile.js | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
http://git.horde.org/horde-git/-/commit/86cee2742665afd3b6d9e41e93521b15e204815e
commit d0086a21043e4aa0b3a989378f56ac252f2ac4dd
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sun Mar 25 22:21:22 2012 -0600
Simplify drop-down header information in smartmobile message screen
Also, move styling to CSS file.
Ticket #11103imp/js/mobile.js | 2 ++
imp/templates/mobile/message.html.php | 8 +++-----
imp/themes/default/mobile.css | 9 +++++++++
3 files changed, 14 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/d0086a21043e4aa0b3a989378f56ac252f2ac4dd
Assigned to Michael Slusarz
State ⇒ Resolved
Assigned to Jan Schneider
1st message you delete.
higher on a touch screen, that's why I added the confirmation
dialog. I'd rather like to add checkboxes to the message list, so
you can bulk-delete messages and only have to confirm once.
added some padding between the "destructive" button row and the rest
of the buttons to prevent accidental deletion. But deletion itself
should not be a destructive action, it either marks the message as
deleted, hiding it in the smartmobile view, or it moves it to the
Trash. But this is not a irreversible action.
I did keep the confirmation for report ham/spam, since they may be
irreversible actions (and are not as common as delete).
This change provides a much cleaner UI experience, not to mention much
faster (you immediately are returned to the mailbox page, allowing the
user to immediately begin viewing other messages).
commit 634ee5c7da44d0a847db2113d084f3340fd9e5e3
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sat Apr 7 14:21:39 2012 -0600
Ticket #11103: Remove confirmation when deleting a messageimp/js/mobile.js | 29 ++++++++++++-----------------
imp/templates/mobile/message.html.php | 21 +++++++++++----------
imp/themes/default/mobile.css | 3 +++
3 files changed, 26 insertions(+), 27 deletions(-)
http://git.horde.org/horde-git/-/commit/634ee5c7da44d0a847db2113d084f3340fd9e5e3
commit b506993cea14ba0713c1cd769a1822259823a920
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sat Apr 7 13:53:00 2012 -0600
Bug #11103: Re-add delay to showing notifications on page loadThis event is being fired too quickly, so the history is not being
updated before switching to the notification view. This was completely
breaking the ability to use the smartmobile view on actual smartmobile
devices (e.g. Galaxy Nexus), since closing the notification window was
returning to the previous page in the history - the login page - instead
of the previous view in the current page.
This is a total hack, but I couldn't figure out any other way of doing
this in either jquery or jquery mobile. Not sure if this has been fixed
for 1.1.
.../Notification/Listener/SmartmobileStatus.php | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/b506993cea14ba0713c1cd769a1822259823a920
comment. We *are* using onpagechange. But there was a weird lastHash
kind of caching thing that was breaking a bunch of stuff. I removed
it and everything works better now.
commit 86cee2742665afd3b6d9e41e93521b15e204815e
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Mar 28 19:05:54 2012 -0600
Bug #11103: Fix reloading views in smartmobile viewNot sure why this is needed. onchangepage should only be triggered if
the hash changes anyway. And this was preventing viewport cache
updates.
imp/js/mobile.js | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
http://git.horde.org/horde-git/-/commit/86cee2742665afd3b6d9e41e93521b15e204815e
trying almost *every* page change/load event that jqm offers. The
current code is the only method that reliably worked across all tested
browsers/situations so far.
changes. I think that's the issue behind the report spam problems.
There's also an issue with moving from the folders -> mailbox list, if
the mailbox list is already loaded. No imp mobile js code is
triggered in this instance, so the mailbox cache can not be verified
as accurate.
I'm almost 100% sure we should be using 'pagebeforechange' instead.
See: http://jquerymobile.com/test/docs/api/events.html
spam? Worked fine for me last time I looked, what's wrong now?
screen. This probably has something to do with the caching changes.
message for a moment. When the AJAX request is done there is a brief
switch to the notification page ('The message has been marked as
spam'), but it then immediately switches to the mailbox view, although
a few things aren't correct (the browser title is not always set
correctly; sometimes there is a pager even if the # of messages is
below the threshold).
State ⇒ Feedback
1st message you delete.
higher on a touch screen, that's why I added the confirmation
dialog. I'd rather like to add checkboxes to the message list, so
you can bulk-delete messages and only have to confirm once.
#1thing thatstuck out about the UI experience. It was extremely tedious to go
through my INBOX when I have more than a few new messages.
Using K-9 mail on android, there is no confirmation there and the
button size is somewhat comparable.
Maybe move the "destructive" commands further away from the other commands?
spam? Worked fine for me last time I looked, what's wrong now?
This probably has something to do with the caching changes.
list is almost impossible (a mailbox will be selected instead).
This might be an issue with jquery - if so, we should consider
upgrading (if possible).
for Horde 5 anyway, let's see if it's fixed there.
the 1st message you delete.
higher on a touch screen, that's why I added the confirmation dialog.
I'd rather like to add checkboxes to the message list, so you can
bulk-delete messages and only have to confirm once.
spam? Worked fine for me last time I looked, what's wrong now?
commit d0086a21043e4aa0b3a989378f56ac252f2ac4dd
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sun Mar 25 22:21:22 2012 -0600
Simplify drop-down header information in smartmobile message screen
Also, move styling to CSS file.
Ticket #11103imp/js/mobile.js | 2 ++
imp/templates/mobile/message.html.php | 8 +++-----
imp/themes/default/mobile.css | 9 +++++++++
3 files changed, 14 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/d0086a21043e4aa0b3a989378f56ac252f2ac4dd
3 items: Date (which is already displayed on the page), From
(already displayed on the page) and To. Seems to make more sense to
just show Date/From/To all the time instead.
design to save a bit of screen space.
Priority ⇒ 2. Medium
State ⇒ New
Patch ⇒ No
Milestone ⇒ 6
Summary ⇒ Smartmobile view improvements
Type ⇒ Enhancement
Queue ⇒ IMP
(testing with Galaxy Nexus). Things that need to be fixed/changed for
IMP 6:
* Scroll swipe detection is lousy. Trying to scroll a large folder
list is almost impossible (a mailbox will be selected instead). This
might be an issue with jquery - if so, we should consider upgrading
(if possible).
* Initial notification screen (i.e. last login) causes a reload of the
portal page when closing. This should not happen.
* Delete confirmation has to go. It becomes super annoying after the
1st message you delete.
* Report spam notification is not working properly.
* Do we really need pop-down message information? It only contains 3
items: Date (which is already displayed on the page), From (already
displayed on the page) and To. Seems to make more sense to just show
Date/From/To all the time instead.