Tickets :: [#11091] Re-add show-images-by-address-book

6.0.0-beta1

7/6/25

Summary	Re-add show-images-by-address-book
Queue	IMP
Queue Version	Git develop
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	03/20/2012 (4856 days ago)
Due
Updated	08/29/2012 (4694 days ago)
Assigned
Resolved	03/27/2012 (4849 days ago)
Milestone
Patch	No

08/29/2012 12:33:51 PM	Git Commit	Comment #8	Reply to this comment
Changes have been made in Git (master): commit 1390bd940cd0ff631bd2a42af941bf0cff9abec7 Author: Michael M Slusarz <slusarz@horde.org> Date: Sat Mar 24 08:51:06 2012 -0600 ~~Bug #11091~~: Unblock images when adding to whitelist imp/js/dimpcore.js \| 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/1390bd940cd0ff631bd2a42af941bf0cff9abec7

03/28/2012 09:48:09 AM	Jan Schneider	Comment #7	Reply to this comment
This used to work when adding sender to the address book too. This definitely isn't true for dynamic view. The addContact AJAX call does not define a callback. Yeah, maybe I confused this with the traditional view.

03/27/2012 10:04:38 PM	Michael Slusarz	Comment #6 Assigned to Michael Slusarz State ⇒ Resolved	Reply to this comment
Closing since the original issue doesn't exist (it wasn't removed) and the remaining issues have been fixed.

03/24/2012 02:52:58 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (develop): commit 1390bd940cd0ff631bd2a42af941bf0cff9abec7 Author: Michael M Slusarz <slusarz@horde.org> Date: Sat Mar 24 08:51:06 2012 -0600 ~~Bug #11091~~: Unblock images when adding to whitelist imp/js/dimpcore.js \| 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/1390bd940cd0ff631bd2a42af941bf0cff9abec7

03/24/2012 02:45:23 PM	Michael Slusarz	Comment #4	Reply to this comment
Oh, and while I'm there, though this not exactly the same issue, it would be great to automatically load the images of the current message after whitelisting a sender. I thought it did? Although... it probably doesn't since imageunblock.js does the bare minimum and delegates other features to the base page script via the unblock event. This used to work when adding sender to the address book too. This definitely isn't true for dynamic view. The addContact AJAX call does not define a callback. This doesn't seem like expected behavior to a user either. And it's really not that big of a deal warranting a potentially complicated mechanism to do this for a single message - I can't imaging a user complaining that they had to manually display images in this situation.

03/24/2012 02:35:25 PM	Michael Slusarz	Comment #3 State ⇒ Feedback	Reply to this comment
This should not replace the whitelist by address book recipients though. I'd like to have this back, additionally, and I'm sure users will complain after they upgraded to H5 too. I haven't removed this code. The new image_replacement_addrs preference is in addition to the addressbook whitelist check. See IMP_Ui_Imageview#showInlineImage().

03/20/2012 08:28:43 AM	Jan Schneider	Comment #2	Reply to this comment
Oh, and while I'm there, though this not exactly the same issue, it would be great to automatically load the images of the current message after whitelisting a sender. This used to work when adding sender to the address book too.

03/20/2012 08:26:54 AM	Jan Schneider	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Re-add show-images-by-address-book Queue ⇒ IMP Milestone ⇒ Patch ⇒ No State ⇒ New	Reply to this comment
Not having to store senders in the address book whose messages should have their embedded images displayed is a great feature that I really missed in the past. This should not replace the whitelist by address book recipients though. I'd like to have this back, additionally, and I'm sure users will complain after they upgraded to H5 too.