Tickets :: [#1105] sieve begins/ends with error

6.0.0-beta1

7/11/25

Summary	sieve begins/ends with error
Queue	Ingo
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	1. Low
Owners	Horde Developers (at) , jan (at) horde (dot) org
Requester	tmerritt (at) email (dot) arizona (dot) edu
Created	01/07/2005 (7490 days ago)
Due
Updated	02/07/2005 (7459 days ago)
Assigned	01/27/2005 (7470 days ago)
Resolved	02/07/2005 (7459 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

02/07/2005 10:28:47 AM	Jan Schneider	Comment #10 State ⇒ Resolved	Reply to this comment
Weird, works now. Committed to CVS, thanks.

01/27/2005 01:26:33 PM	tmerritt (at) email (dot) arizona (dot) edu	Comment #9	Reply to this comment
Could you please give me a specific case where it is not added, I can't reproduce this. Thanks.

01/27/2005 01:08:51 PM	Jan Schneider	Comment #8 State ⇒ Feedback	Reply to this comment
I think you convinced me. But the patch is still broken, because the wildcard is not added to all value after the split.

01/27/2005 12:52:52 PM	tmerritt (at) email (dot) arizona (dot) edu	Comment #7	Reply to this comment
Please see line 1481 of ingo/lib/Script/sieve.php for an example of how separating multiple stings with a , is already supported in ingo.

01/19/2005 03:59:05 PM	tmerritt (at) email (dot) arizona (dot) edu	Comment #6	Reply to this comment
They don't support it today because they are broken, every other string/address test in ingo supports multiple strings/addresses separated by ,'s. I believe if you look further in the existing code you'll see that \, is translated into a , allowing ,'s in strings. We're running ingo here with that same patch applied and it does not break anything.

01/19/2005 03:35:35 PM	Jan Schneider	Comment #5 State ⇒ Not A Bug	Reply to this comment
These tests don't support multiple addresses. And your patch doesn't work anyway, because it makes "equal" test of the addresses if you enter them separated by commas.

01/11/2005 06:21:00 PM	Jan Schneider	Assigned to Horde Developers State ⇒ Assigned

01/07/2005 05:29:05 PM	Jan Schneider	Version ⇒ HEAD

01/07/2005 05:20:53 PM	tmerritt (at) email (dot) arizona (dot) edu	Comment #4	Reply to this comment
The patch is against HEAD, which I would have sworn that I chose when I submitted the bug report.

01/07/2005 05:17:27 PM	Jan Schneider	Comment #3 State ⇒ Feedback	Reply to this comment
This patch does not apply to the current RELENG_1 code. Make sure you have an up-to-date checkout.

01/07/2005 05:14:00 PM	Jan Schneider	Assigned to Jan Schneider State ⇒ Assigned

01/07/2005 04:09:28 PM	tmerritt (at) email (dot) arizona (dot) edu	Comment #2 New Attachment: ingo.patch	Reply to this comment
attached is a patch that fixes this problem.

01/07/2005 04:07:59 PM	tmerritt (at) email (dot) arizona (dot) edu	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ sieve begins/ends with error Queue ⇒ Ingo State ⇒ Unconfirmed	Reply to this comment
The sieve script driver does not properly handle ends/begins with if the strings/addresses field has multiple values.