6.0.0-beta1
7/15/25

[#10969] Deleting calendar doesnt delete syncronized events
Summary Deleting calendar doesnt delete syncronized events
Queue Kronolith
Queue Version Git master
Type Bug
State Resolved
Priority 2. Medium
Owners mrubinsk (at) horde (dot) org
Requester goncalo.queiros (at) portugalmail (dot) net
Created 02/07/2012 (4907 days ago)
Due
Updated 02/18/2012 (4896 days ago)
Assigned
Resolved 02/18/2012 (4896 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
02/18/2012 06:55:41 AM Michael Rubinsky State ⇒ Resolved
 
02/18/2012 06:36:22 AM Git Commit Comment #7 Reply to this comment
Changes have been made in Git (develop):

commit cb1db27b72cdd5fccd0a7da0accf13f51bb83478
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Feb 18 01:29:00 2012 -0500

     Avoid prematurley pruning the deleted calendar from the 
sync_calendar pref.

     Final bit for fixing Bug: 10969

  kronolith/lib/Api.php       |    9 ++++++---
  kronolith/lib/Kronolith.php |   29 +++++++++++++++++------------
  2 files changed, 23 insertions(+), 15 deletions(-)

http://git.horde.org/horde-git/-/commit/cb1db27b72cdd5fccd0a7da0accf13f51bb83478
02/18/2012 06:36:06 AM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (develop):

commit 7826091357c8c26ca9ac89f417ddb0b73946f189
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Feb 18 01:27:11 2012 -0500

     Pass back any recently deleted calendars to sync clients as well.

     Otherwise, sync clients will never request changes for the deleted
     calendar - thus will never know to remove their events locally.
     Bug: 10969

  kronolith/lib/Kronolith.php |   10 ++++++----
  1 files changed, 6 insertions(+), 4 deletions(-)

http://git.horde.org/horde-git/-/commit/7826091357c8c26ca9ac89f417ddb0b73946f189
02/18/2012 06:35:50 AM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (develop):

commit 2648f09b99afeb79aea697178cd42e852ab4d4c2
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Feb 18 01:17:03 2012 -0500

     Must delete each event so that History picks up the change.

     We can't just remove the events from storage without telling History
     or sync clients will never be notified. Partially fixes Bug: 10969

  kronolith/lib/Driver/Sql.php |   21 ++++++++++++++-------
  1 files changed, 14 insertions(+), 7 deletions(-)

http://git.horde.org/horde-git/-/commit/2648f09b99afeb79aea697178cd42e852ab4d4c2
02/18/2012 06:31:41 AM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit cb1db27b72cdd5fccd0a7da0accf13f51bb83478
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Feb 18 01:29:00 2012 -0500

     Avoid prematurley pruning the deleted calendar from the 
sync_calendar pref.

     Final bit for fixing Bug: 10969

  kronolith/lib/Api.php       |    9 ++++++---
  kronolith/lib/Kronolith.php |   29 +++++++++++++++++------------
  2 files changed, 23 insertions(+), 15 deletions(-)

http://git.horde.org/horde-git/-/commit/cb1db27b72cdd5fccd0a7da0accf13f51bb83478
02/18/2012 06:31:38 AM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 7826091357c8c26ca9ac89f417ddb0b73946f189
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Feb 18 01:27:11 2012 -0500

     Pass back any recently deleted calendars to sync clients as well.

     Otherwise, sync clients will never request changes for the deleted
     calendar - thus will never know to remove their events locally.
     Bug: 10969

  kronolith/lib/Kronolith.php |   10 ++++++----
  1 files changed, 6 insertions(+), 4 deletions(-)

http://git.horde.org/horde-git/-/commit/7826091357c8c26ca9ac89f417ddb0b73946f189
02/18/2012 06:31:34 AM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 2648f09b99afeb79aea697178cd42e852ab4d4c2
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Feb 18 01:17:03 2012 -0500

     Must delete each event so that History picks up the change.

     We can't just remove the events from storage without telling History
     or sync clients will never be notified. Partially fixes Bug: 10969

  kronolith/lib/Driver/Sql.php |   21 ++++++++++++++-------
  1 files changed, 14 insertions(+), 7 deletions(-)

http://git.horde.org/horde-git/-/commit/2648f09b99afeb79aea697178cd42e852ab4d4c2
02/17/2012 05:24:34 PM Michael Rubinsky Assigned to Michael Rubinsky
 
02/07/2012 03:08:07 PM goncalo (dot) queiros (at) portugalmail (dot) net Comment #1
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Deleting calendar doesnt delete syncronized events
Queue ⇒ Kronolith
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
If you delete a calendar on Kronolith that was already syncronized 
with outlook/phones etc, when you rsync, the events won't be deleted 
on the client.

This happens, because the getChanges method of th Kronolith api, uses 
the calendars available for syncronization to get the events that were 
add/modify/delete.. but since the calendar no longer exists no events 
will be marked as deleted

Saved Queries