6.0.0-alpha12
6/12/25

[#10879] No Validation on vacation start/end dates
Summary No Validation on vacation start/end dates
Queue Ingo
Queue Version 2.0.7
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester it (at) wenn (dot) com
Created 12/22/2011 (4921 days ago)
Due
Updated 08/29/2012 (4670 days ago)
Assigned
Resolved 01/31/2012 (4881 days ago)
Github Issue Link
Github Pull Request
Milestone 2.1
Patch No

History
08/29/2012 12:29:04 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 38f90ba93723c98f9d68974b89df8c377d1393a7
Author: Jan Schneider <jan@horde.org>
Date:   Tue Jan 31 19:33:01 2012 +0100

     [jan] Validate start and end dates of vacation rules (Request #10879).

  ingo/docs/CHANGES          |    1 +
  ingo/lib/Form/Vacation.php |   44 
+++++++++++++++++++++++++++++++++++++++++---
  ingo/package.xml           |    1 +
  3 files changed, 43 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/38f90ba93723c98f9d68974b89df8c377d1393a7
01/31/2012 06:34:26 PM Jan Schneider Assigned to Jan Schneider
State ⇒ Resolved
Milestone ⇒ 2.1
 
01/31/2012 06:34:15 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (refs/heads/develop):

commit 38f90ba93723c98f9d68974b89df8c377d1393a7
Author: Jan Schneider <jan@horde.org>
Date:   Tue Jan 31 19:33:01 2012 +0100

     [jan] Validate start and end dates of vacation rules (Request #10879).

  ingo/docs/CHANGES          |    1 +
  ingo/lib/Form/Vacation.php |   44 
+++++++++++++++++++++++++++++++++++++++++---
  ingo/package.xml           |    1 +
  3 files changed, 43 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/38f90ba93723c98f9d68974b89df8c377d1393a7
12/22/2011 10:48:57 AM it (at) wenn (dot) com New Attachment: vacation.bug10879.patch Download
 
12/22/2011 10:38:59 AM it (at) wenn (dot) com Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ No Validation on vacation start/end dates
Queue ⇒ Ingo
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
There is no validation checks when the end date is prior to the start 
and also no notification to when the end date is prior to today.
I have noticed that many users make mistakes when setting their 
vacation notice and then wander why it never works.
Also noted that with the sieve filter if the end date is prior to the 
start date and the end month is before the start month of the 
incorrect date then the sieve filter is half written.

I am attaching a patch to give some user warnings and also if the 
dates are the wrong way around it will not try and activate the script 
as doing this will mess up the current one that exists.

Saved Queries