Tickets :: [#10827] Kronolith_Resource_Single#addEvent() unused?

6.0.0-beta1

7/4/25

Summary	Kronolith_Resource_Single#addEvent() unused?
Queue	Kronolith
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	12/01/2011 (4964 days ago)
Due
Updated	12/04/2011 (4961 days ago)
Assigned
Resolved	12/04/2011 (4961 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

12/04/2011 10:03:37 PM	Michael Rubinsky	State ⇒ Resolved

12/04/2011 09:55:09 PM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git for this ticket: Refactor a bit of resource calendar handling. Bring resource calendar handling more in line with modern kronolith code, and make it easier to implement in dynamic view. Fixes ~~Bug: 10827~~ 10 files changed, 126 insertions(+), 11 deletions(-) http://git.horde.org/horde-git/-/commit/703771f49c694527759070ae4edb54c45a9be2dd

12/04/2011 08:27:56 PM	Michael Rubinsky	Comment #6	Reply to this comment
I don't see this. If adding an event, the currently displayed resource is the only calendar in the drop down list. Yes, this was due to an unrelated (and now fixed) issue.

12/01/2011 11:28:59 PM	Jan Schneider	Comment #5	Reply to this comment
[Show Quoted Text - 9 lines][Hide Quoted Text] This is actually a broader problem. At one point, when a calendar was being forced viewed, the add links contained the calendar ids, so the new event form would know the calendar id to use. That no longer appears to be the case, so even with "regular" internal calendars, the new event form defaults to the first calendar in the select list...and since resource calendars are never in this list, it is impossible to create an event on a resource's calendar. The calendar id must be passed to the new event form when a calendar is being force viewed. I don't see this. If adding an event, the currently displayed resource is the only calendar in the drop down list.

12/01/2011 11:28:06 PM	Jan Schneider	Comment #4	Reply to this comment
$this->getDriver is defined in the base class. The addEvent method is the event that is called when an event is added to the resource's calendar after it has accepted the event. Ah right, I was looking at Kronolith_Resource, not Kronolith_Resource_Base.

12/01/2011 11:25:34 PM	Michael Rubinsky	Comment #3	Reply to this comment
This is actually a broader problem. At one point, when a calendar was being forced viewed, the add links contained the calendar ids, so the new event form would know the calendar id to use. That no longer appears to be the case, so even with "regular" internal calendars, the new event form defaults to the first calendar in the select list...and since resource calendars are never in this list, it is impossible to create an event on a resource's calendar. The calendar id must be passed to the new event form when a calendar is being force viewed.

12/01/2011 10:43:06 PM	Michael Rubinsky	Comment #2	Reply to this comment
$this->getDriver is defined in the base class. The addEvent method is the event that is called when an event is added to the resource's calendar after it has accepted the event. That being said, explicitly adding an event fails for me too. The event is added to my calendar. I'll have a look, but I know this did work at one point.

12/01/2011 10:18:59 AM	Jan Schneider	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Kronolith_Resource_Single#addEvent() unused? Queue ⇒ Kronolith Assigned to Michael Rubinsky Milestone ⇒ Patch ⇒ No State ⇒ Assigned	Reply to this comment
Is this method used at all or can it be removed? It calls $this->getDriver(), but there is no such method, so maybe this code isn't reached at all? Not sure if this is in any way related, but I cannot explicitly add new events to resource calendars either. I don't get an error message, I just return to the calendar view with the event not added.