Summary | some issues with the new weather block |
Queue | Horde Framework Packages |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | mrubinsk (at) horde (dot) org |
Requester | michael (at) bigmichi1 (dot) de |
Created | 11/27/2011 (4968 days ago) |
Due | |
Updated | 11/30/2011 (4965 days ago) |
Assigned | 11/29/2011 (4966 days ago) |
Resolved | 11/30/2011 (4965 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
also comes from the Horde_Service_Weather package so i didn't update
the horde package
State ⇒ Feedback
problem with the units.
I can't reproduce this with *any* driver, whereas before this change,
I could.
> and that units is
i've looked over the code but didn't find the place where the units
from configuration of the block is set to the driver.
// Set the requested units.
$weather->units = $this->_params['units'];
problem with the units.
units...not sure where you see this at?
Horde_Service_Weather::FORECAST_UNIT_STANDARD.
problem with the units.
i added a Horde::debug($this->_weather) in __get and that units is
everytime 1 (STANDARD) also after changing the block configuration.
i've looked over the code but didn't find the place where the units
from configuration of the block is set to the driver. tried also
another provider, but same result
State ⇒ Resolved
wasn't seeing the behavior. This should be fixed now.
Don't allow changing units on weather data objects after the request.
This can lead to, among other things, incorrect units being displayed
due to a chicken-egg problem in some cases. See
Bug: 1080411 files changed, 24 insertions(+), 47 deletions(-)
http://git.horde.org/horde-git/-/commit/5022988bee6c675827bdc655494280979c437151
Fix returning icon for current condition for Wwo driver.
Bug: 108041 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/8ddfca1ede8a7af90fcd9162059e3323b1a15fbc
Revert "(Unsuccessful) attempt to fix chicken-and-egg problem from
ticket #10804."This reverts commit 3a348cf79f424b01e1fad982c7ec44552c5328a8.
See comments on
Bug: 108041 files changed, 11 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/f3befc3a83fa9078687b2cd66bda4593fbfbec13
getting the weather driver from the injector. The units *are*
determined on demand. When we request a value that can returned in
different units from either the current or period objects, the units
are checked and the appropriate units are returned.
I'm reverting the changes because $_driver is actually never set in
the timeobjects driver anyway, and these changes break setting the
correct units. Also, getForecast() doesn't allow you to pass the
units...not sure where you see this at?
I made changes not too long ago that deal with Google returning
whatever units it seems fit. I cannot reproduce this locally, using
the calendar block and the weather block, with the Google driver or
the Wwo driver (which is what the OP is using). I've tried using
Germal locale, with both European and US locations.
the google driver fetches all information at one.
This is a problem if you have a calendar block including weather
information from timeobjects before the weather block. The timeobjects
driver is trying to guess the location, and set the requested unit
based on the current location. But to find a valid location, it
requests data from Google, instantiating the singleton weather object,
getting the weather data together with the location data, and no
longer requesting the (now cached) weather data when this is needed.
So it doesn't help resetting the unit property after instantiating the
weather object.
The solution could be to do the unit conversions on-demand, i.e. only
when actually calling getCurrentConditions() etc. getForecast() even
allows to pass the units (getCurrentConditions() doesn't), but it's
not used.
(Unsuccessful) attempt to fix chicken-and-egg problem from
ticket #10804.1 files changed, 5 insertions(+), 11 deletions(-)
http://git.horde.org/horde-git/-/commit/3a348cf79f424b01e1fad982c7ec44552c5328a8
New Attachment: new_block.JPG
only two points:
1. missing picture
2. units are not converted
State ⇒ Feedback
WorldWeatherOnline, but we also were not passing the condition text
through the translate method. That has been fixed, and the list of
strings should be added before the package is released as stable
though of course, they will still need to be translated...
There *was* an issue with displaying the wrong units, but that was
already fixed in Git a few days ago. I cannot reproduce this any
longer. Are you sure you are running the latest Git code?
I can't speak to the problem with the translation file being
displayed...that's more Jan's area of expertise :)
Run conditions text through Horde_Service_Weather_Translation::t
Still need to add the full list of strings returned from Wwo...
Partially fixes
Bug: 108042 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/52e1382a845ec118b6d8c769d9548959d95a3b85
rebooting the entire server didn't fix it. clearing browser cache
didn't help eighter
Assigned to Michael Rubinsky
displayed, from my simple point of view, have a look at the first
screenshot.
metrics in block configuration see second screenshot
can you see on the first screenshot
Priority ⇒ 1. Low
State ⇒ Unconfirmed
New Attachment: block.jpg
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ some issues with the new weather block
Type ⇒ Bug
displayed, from my simple point of view, have a look at the first
screenshot.
the second one is that temperature is still in F, but i configured
metrics in block configuration see second screenshot
the thirsd on is that some things are not translated, like sunny as
can you see on the first screenshot