Summary | Reply doesn't work after showing unsubscribed folders |
Queue | IMP |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | jan (at) horde (dot) org |
Created | 11/16/2011 (4957 days ago) |
Due | |
Updated | 02/01/2012 (4880 days ago) |
Assigned | 02/01/2012 (4880 days ago) |
Resolved | 02/01/2012 (4880 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Taken from Jan Schneider
State ⇒ Resolved
preventing any view from being purged from the viewport cache. In
other words, it was working in IMP 5.1 by accident.
commit 590f727ca0f2793222975d2a8d2c5112c075f830
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Feb 1 13:54:28 2012 -0700
[mms] Fix reloading the folder list in the dynamic view (
Bug #10769).imp/docs/CHANGES | 1 +
imp/js/viewport.js | 5 +++++
imp/package.xml | 2 ++
3 files changed, 8 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/590f727ca0f2793222975d2a8d2c5112c075f830
commit 590f727ca0f2793222975d2a8d2c5112c075f830
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Feb 1 13:54:28 2012 -0700
[mms] Fix reloading the folder list in the dynamic view (
Bug #10769).imp/docs/CHANGES | 1 +
imp/js/viewport.js | 5 +++++
imp/package.xml | 2 ++
3 files changed, 8 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/590f727ca0f2793222975d2a8d2c5112c075f830
State ⇒ Assigned
just for 5.0.x.
2. Select a message
3. Toggle subscribed/unsubscribed folders (direction doesn't matter)
=> triggers pasted backtrace
4. Hit reply
is explicitly deleted, this is the backtrace (1 or 2 lines off in
dimpbase.js):
deleteView(view="SU5CT1g")viewport.js (Zeile 354)
deleteFolderElt(fid="fldSU5CT1g", sub=true)dimpbase.js (Zeile 3124)
(?)(elt=li#fldSU5CT1g.folder)dimpbase.js (Zeile 3150)
each(value=li#fldSU5CT1g.folder)prototype.js (Zeile 825)
each(iterator=function(), context=Object { INBOX="SU5CT1g",
lastrow=klass, pivotrow=klass, mehr...})prototype.js (Zeile 824)
_reloadFolders()dimpbase.js (Zeile 3151)
toggleSubscribed()dimpbase.js (Zeile 3141)
contextOnClick(parentfunc=function(), e=dataavailable )dimpbase.js (Zeile 971)
bind()prototype.js (Zeile 391)
wrap()prototype.js (Zeile 429)
bindAsEventListener(event=dataavailable )prototype.js (Zeile 399)
responder(event=dataavailable )prototype.js (Zeile 5575)
fire(element=span#anonymous_element_5.iconImg,
eventName="ContextSensitive:click", memo=Object {
elt=a#ctx_folderopts_sub, trigger="ctx_folderopts"},
bubble=true)prototype.js (Zeile 5734)
_methodized()prototype.js (Zeile 438)
_leftClickHandler(e=click clientX=115, clientY=505)contex...tive.js
(Zeile 196)
bindAsEventListener(event=click clientX=115, clientY=505)prototype.js
(Zeile 399)
responder()prototype.js (Zeile 5598)
event = click clientX=115, clientY=505
Assigned to Jan Schneider
Assigned to Michael Slusarz
Ways I tried to reproduce:
1. Select message in subscribed mailbox.
2. Show All mailboxes
3. Verify you can still reply to message.
4. Hide unsubscribed
5. Verify you can still reply to message (or any other message in mailbox).
Also:
1. Show All mailboxes
2. Open unsubscribed mailbox
3. Select message.
4. Hide unsubscribed
5. Verify you can still reply to message (or any other message in mailbox).
State ⇒ Feedback
and then hiding unsubscribed folders, I noticed that the reply button
doesn't work because no message is considered selected anymore, see
comment 6.
This happens because in ViewPort::_getBuffer() a new ViewPort_Buffer
is created, because this.views is an empty hash.
State ⇒ Resolved
Bug #10886.Bug #10769: Explicitly catch exceptions in critical viewport methodsIn methods that set isbusy, we need to catch exceptions so that we can
reset the value of isbusy, or else viewport requests will enter an
infinite loop.
1 files changed, 33 insertions(+), 14 deletions(-)
http://git.horde.org/horde-git/-/commit/e8677baa513291c0d577d5ba675472dca5862ee0
highlighted (from before showing all folders), but it's not marked
as selected internally, i.e. the preview is not displayed, and if I
try to drag the message, it says "0 messages..." again. I cannot
select any other message either.
true, but the code is crashing before it can be set back to false.
Thus all other calls to ViewPort are entering infinite loops because
they are waiting isbusy to return to being false.
I've hesitated putting try/catch() statements around these calls
because it may leave the viewport in an incorrect state and, IIRC,
errors in the try/catch statement will not bubble up to tools like
firebug. Although in the latter case, I think that we can re-throw
the exception and this will fix that issue.
But the underlying issue needs to be debugged on the server where it
is seen. So you'll have to catch this in the future and poke around
to discover the issue.
highlighted (from before showing all folders), but it's not marked as
selected internally, i.e. the preview is not displayed, and if I try
to drag the message, it says "0 messages..." again. I cannot select
any other message either.
State ⇒ Feedback
Unfortunately (or fortunately, give my earlier experience) Firebug was
not running, so I don't have a backtrace:
Fehler: vs.get("dataob").first() is undefined
Quelldatei: http://neo.wg.de/headhorde/imp/js/dimpbase.js
Zeile: 3287
State ⇒ Not A Bug
snippet of IMP code triggers issues in the javascript engine, that's
still a FF problem, not ours.
multiple messages, and they are highlighted correctly, but when I try
to drag them, it says "0 messages...".
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ Reply doesn't work after showing unsubscribed folders
Type ⇒ Bug
select to show all folders in the "Other Actions" popdown, I can no
longer open a reply window to a message that worked before just fine.
Trying to track this down with Firebug crashed the browser completely,
so I'm not sure if this isn't some internal problem instead. FF 7.0.1.