| Summary | fb.php |
| Queue | Kronolith |
| Queue Version | 3.0.11 |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | jan (at) horde (dot) org |
| Requester | michael.groene (at) zel (dot) uni-hannover (dot) de |
| Created | 11/15/2011 (4984 days ago) |
| Due | |
| Updated | 11/15/2011 (4984 days ago) |
| Assigned | |
| Resolved | 11/15/2011 (4984 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | 3.0.12 |
| Patch | No |
Assigned to Jan Schneider
State ⇒ Resolved
Milestone ⇒ 3.0.12
Fix logic (
Bug #10766).1 files changed, 3 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/5275828e9e5933bda8ba40af44ff82dd3ada05c3
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Queue ⇒ Kronolith
Summary ⇒ fb.php
Type ⇒ Bug
State ⇒ Unconfirmed
// If the free/busy calendars preference is empty, default to
// the user's default_share preference, and if that's empty,
// to their username.
if (!$cal) {
$cal = 'internal_' . $prefs->getValue('default_share');
if (!$cal) {
$cal = 'internal_' . $user;
}
}
Am I wrong, or will the innermost if-condition never be true?
"internal_" will be stored in every case, which makes the next if
redundant!?