Summary | Password is not updated in session |
Queue | Passwd |
Queue Version | 4.0 |
Type | Bug |
State | Duplicate |
Priority | 1. Low |
Owners | |
Requester | azurit (at) pobox (dot) sk |
Created | 11/02/2011 (4994 days ago) |
Due | |
Updated | 12/20/2011 (4946 days ago) |
Assigned | |
Resolved | 11/02/2011 (4994 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
I started to digging deeper into this and i found out something
interesting. When password is changed it is reseted in cache via
resetCredentials function. This function is reseting password stored
in memory (in session). Problem is that password from session is NEVER
used for logging into IMAP server.
Login to IMAP is done via Horde_Imap_Client which takes login and
password as argument (in $params) and these values are set ONLY in
constructor (this is done by Horde/IMP in createImapObject function
called in Auth.php). Problem is that IMAP object is initialized only
ONCE per IMAP login in our installation - so, when password changes,
it is correctly updated in session but gets NEVER updated in IMAP
object. I was doing some debug logging inside Horde and Horde/IMP and
it is really like this, constructor for Horde_Imap_Client is called
only once per login, the IMAP object is probably serialized and cached
somewhere.
Sending patch which works for me:
File: passwd/lib/Passwd.php
Function (at the end of file): resetCredentials
Code (i added 3 lines which starts by '$imp_imap'):
static public function resetCredentials($old_password, $new_password)
{
if ($GLOBALS['registry']->getAuthCredential('password') ==
$old_password) {
$GLOBALS['registry']->setAuthCredential('password',
$new_password);
$imp_imap =
$GLOBALS['injector']->getInstance('IMP_Factory_Imap')->create();
$imp_imap->ob = NULL;
$imp_imap->createImapObject($GLOBALS['registry']->getAuth(),
$new_password, IMP_Auth::getAutoLoginServer());
}
}
State ⇒ Duplicate
Priority ⇒ 1. Low
#10228and I still don't see this (anymore).Priority ⇒ 3. High
Patch ⇒ No
Milestone ⇒
Queue ⇒ Passwd
Summary ⇒ Password is not updated in session
Type ⇒ Bug
State ⇒ Unconfirmed
server but is NOT updated in Horde session. You need to logout and
login from/to Horde or nothing will work after password is changed.