Yes i think it's fixed.

The alarm notification/email is correctly set with event start hour 
and the alarms are showed/send correctly.

You may close the ticket.

Thanks !!!

fix for Bug: 10678

Changes have been made in Git for this ticket:

$event->start is the start time for the event, not the alarm.
Fixes the alarm notification text from showing the alarm time,
not the event start time. (Final?) fix for Bug: 10678

  1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/f27b0596d5423aa12050a6621938ee57df3490fe

I don't see this. I see alarm_start being set to the configured time 
for the alarm. i.e., If I create an event for 13:00, and say to remind 
me 15 minutes prior,  it is saved as 12:45 (adjusted for GMT, of 
course).
This I *do* see...the time displayed in the notification is the 
alarm_start time, not the event_start time (so with a 15 minute prior 
alarm setting,  it shows the event start time 15 minutes early).
This I can't reproduce. I've tried all types of different times, event 
lengths etc..

0) Current time: 13:00, Tuesday
1) Create a daily recurring event on Monday at 11:00, for 1 hour with 
a 15 minute prior alarm. Correctly, no alarm is shown.
2) Create a daily recurring event on Monday at 12:30, for 1 hour with 
15 minute prior alarm: Since the current time is within this event's 
timespan, an alarm is shown immediately after saving.
3) Create a daily recurring event on Monday at 14:00 with 15 minute 
prior alarm. No alarm is shown until 13:45.

Which of these cases is failing for you? The only thing broken that I 
can see locally is the displayed start time of the event in the 
notification...
The last commit is needed to catch (2) above. If we are past the 
current occurrence's start time, but not past it's end time, the code 
that calculates the next occurrence will not count the current event, 
so the event will potentially be missed when polling for alarms.

Hello again,

your first commit (the older one) fixed the missing alarm notifications,

but the horde alarm, alarm_start is not being set correctly, because 
is equal to event creation time - 5 minuts or something like that,

and the event start hour that is showed in the alarm popup 
notification is the event hour start - the event_alarm time, set in 
event.

If i create one recurring event in the past with start hour - 
event_alarm time set after current hour, the notification is showed in 
the current session, but if the start hour - event_alarm time is later 
than current hour, the event alarm is not showed until logout/login.

The second commit (the recent) doesn't change anything, that i noticed.

I will apply your patches to a more recent repository and i will reply 
again to this ticket.

Thanks, one more time.

Ok, *now* it should be fixed...

can you verify it works ok for you?

Changes have been made in Git for this ticket:

Fix polling alarms for recurring events during the event's timespan.
If the datetime we are polling for alarms is during a recurrence of
a recurring event (it is currently after $event->start but before
$event->end) then nextRecurrence will not return the current event.
Normalize the date to midnight to be sure we capture the day's
recurrence. Bug: 10678

  1 files changed, 9 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/095ae11aeba788dc972d7c41c92b97baf9cb1231

Changes have been made in Git for this ticket:

Revert "Fix listing alarms for recurring events."
This reverts commit b0373bc44c9e6ff2aa3e2cdda1a6286450031668.

The change causes alarms to show too early in the sidebar. Reverting this
causes the alarms to show in the sidebar on time now, but the in-line alarms
do not show. Bug: 10678

  1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/a8584835500bad35357bf81bcb80e6cc3fa849e4

Can you verify that what I committed fixes this for you? Local tests 
seem to work correctly.

Changes have been made in Git for this ticket:

Fix listing alarms for recurring events.
This condition would never be true for a recurring event, since $start
is taken from the nextRecurrence(). Bug: 10678

  1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/b0373bc44c9e6ff2aa3e2cdda1a6286450031668

Changes have been made in Git for this ticket:

Need to tweak $event->end if this is a single instance of a recurring event.
Bug: 10678

  1 files changed, 44 insertions(+), 8 deletions(-)
http://git.horde.org/horde-git/-/commit/75ba025682ade08bce9acf8f73cac47e8d9e9278

Confirmed. The problem in this case is that when $date is a recurring 
event, the $event->end time is of the *original* event, not the 
current occurrence so $eventEnd is actually calculated to be before 
$eventStart.

Hello.

I created one event with daily repetitions and set alarm (inline and 
email) but the alarms don't work in event instances.

Only works in the first instance of the event, in the next ones, the 
alarms are not showed properly.

Thanks in advance.