[#1060] moving rules
Summary moving rules
Queue Ingo
Queue Version 1.0
Type Enhancement
State Resolved
Priority 1. Low
Owners
Requester ivan (dot) zilic (at) mainnetworks (dot) net
Created 01/03/2005 (1465 days ago)
Due
Updated 07/25/2005 (1262 days ago)
Assigned 01/03/2005 (1465 days ago)
Resolved 07/25/2005 (1262 days ago)
Attachments ingo-move-v2.patch Download
ingo-sort.patch Download
Milestone
Patch No

History
07/25/2005 Jan Schneider Comment #7
State ⇒ Resolved		 Reply to this comment
Tweaked and committed, thanks.
07/25/2005 gergely (at) risko (dot) hu Comment #6 Reply to this comment
Ohh, and one note: please use RISKO Gergely <gergely@risko.hu>, 
instead of risko@risko.hu in changelog entries, so google can find it ;)

Thanks,
Gergely

07/25/2005 risko (at) risko (dot) hu Comment #5
New Attachment: ingo-move-v2.patch Download		 Reply to this comment

[Hide Quoted Text]
Looks fine so far, but I have severaly comments/suggestions:

- Don't use a POST submit, but a document.location redirection.
- Use the rule_up/rule_down actions, just add an optional offset. You
can do the calculation with JavaScript.
- in ruleUp()/ruleDown() merge the while() test into the for() test.
- Move the JavaScript to a separate function in filters/header.inc.
Thanks for the feedback, here is the result.

Gergely
07/25/2005 Jan Schneider Comment #4
State ⇒ Feedback		 Reply to this comment
Looks fine so far, but I have severaly comments/suggestions:

- Don't use a POST submit, but a document.location redirection.
- Use the rule_up/rule_down actions, just add an optional offset. You 
can do the calculation with JavaScript.
- in ruleUp()/ruleDown() merge the while() test into the for() test.
- Move the JavaScript to a separate function in filters/header.inc.
07/24/2005 risko (at) risko (dot) hu Comment #3
New Attachment: ingo-sort.patch Download		 Reply to this comment
This has been brought up on the ingo list *many* times and, so far,
no one has submitted a patch that handles this gracefully.
I attach a proposal.

Please note, that there is debbuging output, etc., I just submit it, 
because now I have to sleep and I hope for some feedback by tomorrow ;)

Is it basically acceptable?  Where should I put "long" generated javascripts?

Thanks,
Gergely
01/03/2005 Michael Slusarz Comment #2
State ⇒ Assigned		 Reply to this comment
This has been brought up on the ingo list *many* times and, so far, no 
one has submitted a patch that handles this gracefully.
01/03/2005 ivan (dot) zilic (at) mainnetworks (dot) net Comment #1
State ⇒ New
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ moving rules
Queue ⇒ Ingo		 Reply to this comment
it would great to have a position number for each rule, and be able to 
make changes in their positions using this numbers, specially when 
having lots of rules.

Best Regards,

IVAN