Summary | Weekday calculation error when "first weekday" set to Monday |
Queue | Kronolith |
Queue Version | 2.0 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | chuck (at) horde (dot) org |
Requester | goncal.badenes (at) icfo (dot) es |
Created | 12/31/2004 (7499 days ago) |
Due | |
Updated | 01/04/2005 (7495 days ago) |
Assigned | 01/03/2005 (7496 days ago) |
Resolved | 01/04/2005 (7495 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
I've committed the fix - thanks!
New Attachment: diff.txt
the "show calendars side by side" is also selected (which was the case
for me!).
If my understanding is correct, the bug can then be tracked down to
templates/month/head_side_by_side.inc, which does not take into
account the offset in the day of the month if Monday has been chosen
as the first weekday.
I have patched head_side_by_side.inc and everything seems to be
working fine for me now. However, I would feel more confident if you
could take a look at the patch (attached) and check whether this is
the correct way of solving the problem and/or whether it would break
something else.
Cheers,
Gonçal
State ⇒ Feedback
numbers, but only that the column labels are wrong - do events appear
on the right day numbers?
Take a look in kronolith/templates/month/head.inc and see if you can
see why the weekday generation is not starting with Monday.
New Attachment: calendar-bug.gif
"week starts on Monday" is selected, the month view still shows Sunday
as the first day of the week, and the week day calculation is off by
one day. I'm attaching a screen capture that shows what I get on the
screen.
I can send you the config files if you wish. If I can help in any way
to solve the problem please let me know. Sorry for the
misunderstandings.
State ⇒ Not A Bug
Sun30 Mon31 Tue1 Wed2 etc.
Month view for February 2005 with "week starts on Monday"
Sun31 Mon1 Tue2 Wed3 etc.
- look up. The whole point of "week starts on Monday" is that Monday
is then the first day shown on the left, in the month and week views.
it I just realised that the problem *only* seems to appear in the
*month view*.
Here goes the detailed description:
Month view for February 2005 with the default "week starts on Sunday":
Sun30 Mon31 Tue1 Wed2 etc.
Month view for February 2005 with "week starts on Monday" setting in
the User Interface options:
Sun31 Mon1 Tue2 Wed3 etc.
Week and work week views are OK. Also, weekday calculation within the
"create a new event" window is fine.
State ⇒ Feedback
*where* you see this, so I don't know, but I suspect you didn't notice
that you were in the wrong year - a problem I just fixed.
Assigned to Chuck Hagenbuch
State ⇒ Assigned
also if you see this anyplace else.
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Weekday calculation error when "first weekday" set to Monday
Queue ⇒ Kronolith
State ⇒ Unconfirmed
"first weekday" to monday in my kronolith options. Everything goes
back to normal if "first weekday" is set to sunday.